Igniters, Fix is ready. Code checked by Nikolay Izhikov, all issues fixed Code benchmarked by Ilya Suntsov, no drop found.
Fix *affects public API*, so I'm proposing everyone interested check it. Issue: https://issues.apache.org/jira/browse/IGNITE-8446 PR: https://github.com/apache/ignite/pull/4036/files Public API changes: New EvenType: EVT_TX_STARTED = 129. New Event: TransactionEvent extends EventAdapter { private IgniteInternalTx tx; } In case there are no objection I'll merge the changes soon. пт, 6 апр. 2018 г. в 14:12, Anton Vinogradov <a...@apache.org>: > >> But I have concern > >> about performance. How can you estimate impact to performance ? > We have to benchmark result. > > >> How about to set label name with some useful info if user does not > provide > >> custom name? > You can set custom listener which will do that > > >> For example thread name + global counter? > Or even full stacktrace > > >> how the user is expected to use this event? > Event will be used to validate tx on creation. > Since listner will be invoked at same thread (Am I right?) it will have > all requred info for validation. > > > 2018-04-05 22:06 GMT+03:00 Denis Magda <dma...@apache.org>: > >> Guys, >> >> Sorry for a dumb question but how the user is expected to use this event? >> >> -- >> Denis >> >> On Thu, Apr 5, 2018 at 6:06 AM, Anton Vinogradov <a...@apache.org> wrote: >> >> > Igniters, >> > >> > As far as I know we're working on additional 'label' field for >> transactions >> > [1]. >> > That's great and will be helpful for customers with huge deploymens to >> see >> > reason of each transaction. >> > But, since 'label' is optional field, there is no way to guarantee it >> will >> > be filled. >> > >> > I'd like to propose an idea of brand new event EVT_USR_TX_CREATED (local >> > transaction created). >> > >> > Local listener on such event will allow to guarantee tx's 'label' field >> > filled, timeout is correct and so on. >> > >> > Thoughts? >> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-6827 >> > >> > >
