> > With which one — current implementation in issue?
That's the answer to your question: 1. quickly fix all of them (can be solved by preliminary preparations — searching for -fabric- usages in build configuration); 2. update all branches to master because otherwise old branch will stop building. -- Denis On Thu, Jun 7, 2018 at 1:12 PM, Petr Ivanov <mr.wei...@gmail.com> wrote: > > > On 7 Jun 2018, at 23:04, Denis Magda <dma...@apache.org> wrote: > > > > I'm fine with the suggested approach. > > With which one — current implementation in issue? > > > > However, not sure we need to update > > all the branches. Can't branch owners just pull the changes back from > > master if the plan to merge back later? > > Of course, we as an initiative group of this issue should do nothing, it > will lie on shoulders of developers. > > > > > > -- > > Denis > > > > On Thu, Jun 7, 2018 at 12:57 PM, Petr Ivanov <mr.wei...@gmail.com> > wrote: > > > >> Denis, > >> > >> > >> The most simple approach — repack and rearchive binary archive after > >> release build, however that would not resolve the problem globally (and > >> will require fixing every build configuration we have on TeamCity). > >> Current approach implemented in task — creates already correct folder > and > >> binary archive name, but old name (with -fabric-) is used in almost > every > >> build configuration too and merge code to master will require to: > >> 1. quickly fix all of them (can be solved by preliminary preparations > >> — searching for -fabric- usages in build configuration); > >> 2. update all branches to master because otherwise old branch will > >> stop building. > >> > >> WDYT? > >> > >> > >> > >>> On 7 Jun 2018, at 22:42, Denis Magda <dma...@apache.org> wrote: > >>> > >>> Petr, > >>> > >>> Thanks for pulling up the conversation. > >>> > >>> I still prefer us not to complicate the things and just remove "fabric" > >>> from the *package name*. Use the easiest way possible. > >>> > >>> Personally, I don't care about Hadoop and would not suggest the > community > >>> wasting its time on it. So, just rename the suffixes/prefixes of the > >> build > >>> files the way you like to address Anton's concerns. > >>> > >>> -- > >>> Denis > >>> > >>> > >>> On Thu, Jun 7, 2018 at 1:49 AM, Petr Ivanov <mr.wei...@gmail.com> > wrote: > >>> > >>>> Igniters, > >>>> > >>>> > >>>> Lets define once again what should be done in this [1] task? > >>>> If current implementation is good, than I’ll update it to master and > >> pass > >>>> for review. > >>>> > >>>> Yet, there is other part of the task which concerns our build server > — I > >>>> assume that almost all our build configurations will fail due to name > >>>> change and there is no simple way of updating configurations other > then > >>>> merge task to master and start fixing failing builds. > >>>> > >>>> > >>>> [1] https://issues.apache.org/jira/browse/IGNITE-7251 > >>>> > >>>> > >>>> > >>>>> On 10 Feb 2018, at 01:56, Denis Magda <dma...@apache.org> wrote: > >>>>> > >>>>>> I don't think we necessarily need to remove 'fabric' word from every > >>>> file > >>>>>> in the project, we just need to rename the name of downloadable > >> package. > >>>>> > >>>>> Couldn’t say it better than you, Val. Thanks for pitching in :) This > is > >>>> exactly what the ticket is about. > >>>>> > >>>>> — > >>>>> Denis > >>>>> > >>>>>> On Feb 9, 2018, at 11:53 AM, Valentin Kulichenko < > >>>> valentin.kuliche...@gmail.com> wrote: > >>>>>> > >>>>>> Anton, > >>>>>> > >>>>>> I don't think we necessarily need to remove 'fabric' word from every > >>>> file > >>>>>> in the project, we just need to rename the name of downloadable > >>>> package. Is > >>>>>> there any other place where 'fabric' is exposed to the user? > >>>>>> > >>>>>> If that's the case, it should not be a big change, no? > >>>>>> > >>>>>> -Val > >>>>>> > >>>>>> On Fri, Feb 9, 2018 at 3:49 AM, Anton Vinogradov < > >>>> avinogra...@gridgain.com> > >>>>>> wrote: > >>>>>> > >>>>>>> Denis, > >>>>>>> > >>>>>>> You're proposing changes without viewing a code :) > >>>>>>> > >>>>>>> > >>>>>>> On Thu, Feb 8, 2018 at 10:07 PM, Denis Magda <dma...@apache.org> > >>>> wrote: > >>>>>>> > >>>>>>>> Anton, > >>>>>>>> > >>>>>>>> What’s wrong if we just go ahead and: > >>>>>>>> - replace “fabric” with “ignite” > >>>>>>>> - replace “hadoop” with “ignite-hadoop" > >>>>>>>> > >>>>>>>> — > >>>>>>>> Denis > >>>>>>>> > >>>>>>>>> On Feb 8, 2018, at 1:51 AM, Anton Vinogradov < > >>>> avinogra...@gridgain.com > >>>>>>>> > >>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>> Denis, > >>>>>>>>> > >>>>>>>>> "hadoop" and "fabric" words work on same engine. > >>>>>>>>> > >>>>>>>>> We have special assembly desctiptors, for example: > >>>>>>>>> dependencies-fabric.xml > >>>>>>>>> dependencies-fabric-lgpl.xml > >>>>>>>>> dependencies-hadoop.xml > >>>>>>>>> release-base.xml > >>>>>>>>> release-fabric.xml > >>>>>>>>> release-fabric-base.xml > >>>>>>>>> release-fabric-lgpl.xml > >>>>>>>>> release-hadoop.xml > >>>>>>>>> > >>>>>>>>> So, I'ts impossible for now to remove "fabric" without "hadoop" > >>>>>>> removal. > >>>>>>>>> Only one case is to make some ditry hack, but that's not a good > >> idea. > >>>>>>>>> > >>>>>>>>> On Thu, Feb 8, 2018 at 11:29 AM, Sergey Kozlov < > >> skoz...@gridgain.com > >>>>> > >>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>>> +1 hadoop accelerator removing for AI 2.5 > >>>>>>>>>> > >>>>>>>>>> Also probably IGFS should be either removed or refactored, e.g. > >>>> create > >>>>>>>> FS > >>>>>>>>>> directly over the data region without using "cache" entity as an > >>>>>>>>>> intermidiate stage > >>>>>>>>>> > >>>>>>>>>> On Thu, Feb 8, 2018 at 2:13 AM, Denis Magda <dma...@apache.org> > >>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> Anton, > >>>>>>>>>>> > >>>>>>>>>>> I don’t get how the hadoop editions are related to this task. > The > >>>>>>>> project > >>>>>>>>>>> is not named as “data fabric” for a while. Check up the site or > >>>> docs. > >>>>>>>>>>> > >>>>>>>>>>> The “fabric” word is being removed from all over the places and > >>>> needs > >>>>>>>> to > >>>>>>>>>>> be removed from the editions’ names. > >>>>>>>>>>> > >>>>>>>>>>> As for the hadoop future, my personal position is to retire > this > >>>>>>>>>> component > >>>>>>>>>>> and forget about it. I would restart the conversation again > after > >>>> we > >>>>>>>> done > >>>>>>>>>>> with 2.4. > >>>>>>>>>>> > >>>>>>>>>>> — > >>>>>>>>>>> Denis > >>>>>>>>>>> > >>>>>>>>>>>> On Feb 7, 2018, at 2:13 AM, Anton Vinogradov <a...@apache.org> > >>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>> Denis, Petr, > >>>>>>>>>>>> > >>>>>>>>>>>> I checked PR and found we have *overcomplicated* logic with > >>>> "fabric" > >>>>>>>>>> and > >>>>>>>>>>>> "hadoop" postfixs. > >>>>>>>>>>>> > >>>>>>>>>>>> Do we really need to assembly 2 editions? > >>>>>>>>>>>> "Hadoop" edition still valued? > >>>>>>>>>>>> > >>>>>>>>>>>> My proposal is to get rid of "hadoop" edition and replace it > >> with > >>>>>>>>>>>> instruction of how to use "fabric" edition instead. > >>>>>>>>>>>> Instruction will be pretty easy -> move "hadoop" folder from > >>>>>>>> "optional" > >>>>>>>>>>> to > >>>>>>>>>>>> root directory :) > >>>>>>>>>>>> > >>>>>>>>>>>> In that case we can just remove all postfix logic from maven > >> poms > >>>>>>> and > >>>>>>>>>>>> simplify release process. > >>>>>>>>>>>> > >>>>>>>>>>>> On Thu, Dec 28, 2017 at 9:20 PM, Denis Magda < > dma...@apache.org > >>> > >>>>>>>>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>>> Petr, thanks for solving it! > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hope that Anton V. or some other build master will > double-check > >>>> the > >>>>>>>>>>>>> changes and merge them. > >>>>>>>>>>>>> > >>>>>>>>>>>>> — > >>>>>>>>>>>>> Denis > >>>>>>>>>>>>> > >>>>>>>>>>>>>> On Dec 28, 2017, at 8:29 AM, Petr Ivanov < > mr.wei...@gmail.com > >>> > >>>>>>>>>> wrote: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> IGNITE-7251 is done, needs review and some additional tests. > >> See > >>>>>>> PR > >>>>>>>>>>>>> #3315 [1]. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> [1] https://github.com/apache/ignite/pull/3315 < > >>>>>>>>>>>>> https://github.com/apache/ignite/pull/3315> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>>> On 20 Dec 2017, at 23:15, Denis Magda <dma...@apache.org> > >>>> wrote: > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Petr, thanks, such a swift turnaround! > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Have you found the one who can asses and review the > changes? > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Maintainers label might be helpful. Just ping them > directly: > >>>>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/How+ > >>>>>>>>>>>>> to+Contribute#HowtoContribute-ReviewProcessandMaintainers < > >>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/How+ > >>>>>>>>>>>>> to+Contribute#HowtoContribute-ReviewProcessandMaintainers> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> — > >>>>>>>>>>>>>>> Denis > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> On Dec 20, 2017, at 12:24 AM, Petr Ivanov < > >>>> mr.wei...@gmail.com> > >>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Assigned myself — done the same work while preparing RPM > >>>>>>> package. > >>>>>>>>>>>>>>>> But for fixing DEVNOTES.txt waiting for review and merge > of > >>>>>>>>>>>>> IGNITE-7107 [1]. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-7107 > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> On 19 Dec 2017, at 22:55, Denis Magda <dma...@apache.org > > > >>>>>>> wrote: > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> All the bids were accepted and the verdict is executed: > >>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-7251 < > >>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-7251> > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> Who is ready to pick this up? > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> — > >>>>>>>>>>>>>>>>> Denis > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> On Dec 19, 2017, at 5:35 AM, Anton Vinogradov < > >>>>>>>>>>>>> avinogra...@gridgain.com> wrote: > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> +1б фо шур > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> On Tue, Dec 19, 2017 at 9:59 AM, Vladimir Ozerov < > >>>>>>>>>>>>> voze...@gridgain.com> > >>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> +1б вуаштшеудн > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> On Tue, Dec 19, 2017 at 2:34 AM, Valentin Kulichenko < > >>>>>>>>>>>>>>>>>>> valentin.kuliche...@gmail.com> wrote: > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> +1 > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> On Mon, Dec 18, 2017 at 12:24 PM, Dmitriy Setrakyan < > >>>>>>>>>>>>>>>>>>> dsetrak...@apache.org > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> +1 (completely agree) > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> On Mon, Dec 18, 2017 at 10:21 AM, Denis Magda < > >>>>>>>>>>> dma...@apache.org> > >>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> Igniters, > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> Apache Ignite binary releases still include “fabric” > >>>> word > >>>>>>> in > >>>>>>>>>>>>> their > >>>>>>>>>>>>>>>>>>>> names: > >>>>>>>>>>>>>>>>>>>>>> https://ignite.apache.org/download.cgi#binaries < > >>>>>>>>>>>>>>>>>>>>>> https://ignite.apache.org/download.cgi#binaries> > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> For instance, this is a full name of the previous > >>>> release > >>>>>>> - > >>>>>>>>>>>>>>>>>>>>>> apache-ignite-fabric-2.3.0-bin. > >>>>>>>>>>>>>>>>>>>>>> It’s a little oversight on our side because the > >> project > >>>>>>> has > >>>>>>>>>> not > >>>>>>>>>>>>> been > >>>>>>>>>>>>>>>>>>>>>> positioned as a fabric for a while. > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> Proposal! Remove “fabric” from the name and have the > >>>>>>> binary > >>>>>>>>>>>>> releases > >>>>>>>>>>>>>>>>>>>>> named > >>>>>>>>>>>>>>>>>>>>>> as - apache-ignite-{version}-bin. > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> If we’re in consensus then let’s make the change in > >> 2.4. > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> — > >>>>>>>>>>>>>>>>>>>>>> Denis > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> -- > >>>>>>>>>> Sergey Kozlov > >>>>>>>>>> GridGain Systems > >>>>>>>>>> www.gridgain.com > >>>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>> > >>>> > >>>> > >> > >> > >