Oleg Ignatenko created IGNITE-9124:
--------------------------------------
Summary: Remove some dead code in math.exceptions and optimization
packages of ML module
Key: IGNITE-9124
URL: https://issues.apache.org/jira/browse/IGNITE-9124
Project: Ignite
Issue Type: Task
Components: ml
Affects Versions: 2.5
Reporter: Oleg Ignatenko
Doing code coverage analysis discovered a bit of unused code:
# in package
[math.exceptions|https://github.com/apache/ignite/tree/master/modules/ml/src/main/java/org/apache/ignite/ml/math/exceptions]
- classes ConvergenceException / MathIllegalStateException,
InsufficientDataException, MathArithmeticException, MathIllegalNumberException
/ NumberIsTooSmallException, NonPositiveDefiniteMatrixException,
NonSymmetricMatrixException, NullArgumentException, SingularMatrixException,
UnknownProviderException. In very early releases of ML these exceptions were
used by some linear algebra code. This code has been very deeply reworked since
but outdated exceptions were left hanging unattended, making rather confusing
impression of the current API.
# in
[optimization|https://github.com/apache/ignite/tree/master/modules/ml/src/main/java/org/apache/ignite/ml/optimization]
- interface Updater and two classes implementing it: BarzilaiBorweinUpdater
and SimpleUpdater. This code has left hanging after cleanup that was made for
release 2.5 (IGNITE-8232). Per my discussion with [~dmitrievanthony] (who most
actively maintains this package) it would be better to remove this code.
This task is to remove code mentioned above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
