Hi Oleg, I am not ultimately sure that it will not do any harm. Red error highlights are designed to attract attention very well. I can imagine that I will be distracted by every unused import. While usually I rely on "Optimize imports" enabled in the commit dialog in IDEA.
But I think that we can try it. ср, 28 нояб. 2018 г. в 21:12, Dmitriy Pavlov <dpav...@apache.org>: > > Sure, I agree to let the discussion run its course and give it a couple of > days so people have a chance to think and chime in. > > I just wanted to show I'm ++1 here and probably we can employ > Commit-Than-Review later > > > ср, 28 нояб. 2018 г. в 20:40, oignatenko <oignate...@gridgain.com>: > > > Hi Dmitry, > > > > When we had preliminary discussion of this with Maxim we both were inclined > > to post it here and let it hang for a while to let dev list folks discuss > > this idea in more details for just in case if we missed some usability > > implications. > > > > Though now that you mentioned it I figured that proposed change is low risk > > and easy to rollback, meaning we can do it the other way round: just merge > > it now and keep in mind an option to revert if further discussion here > > shows > > that this way is wrong for some reason. > > > > If you prefer that we pick this way, changing priorities for TC inspections > > could even be done as a part of another ticket involving this config file, > > IGNITE-10422 - you can probably discuss with Maxim if he would be > > comfortable with that (last time I checked he planned to do implementation > > there). > > > > regards, Oleg > > > > > > > > -- > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > -- Best regards, Ivan Pavlukhin
