Andrey, Multi-JVM tests may also use a static IP finder, but it should use some specific port range instead of being shared. Something like 127.0.0.1:48500..48509 would do.
Denis ср, 5 дек. 2018 г. в 18:34, Vyacheslav Daradur <daradu...@gmail.com>: > I filled a task [1]. > > >> Slava, do you think Platforms tests can be fixed as well or one more > ticket > should be created? > > I'll try to fix them within one ticket, it should be investigated a bit > deeper. > > I'll inform about the task's progress in this thread later. > > Thanks! > > [1] https://issues.apache.org/jira/browse/IGNITE-10555 > On Wed, Dec 5, 2018 at 6:28 PM Andrey Mashenkov > <andrey.mashen...@gmail.com> wrote: > > > > Slava, > > +1 for your proposal. > > Is there any ticket for this? > > > > Denis, > > I've just read in nabble thread you suggest to allow multicast finder for > > multiJVM tests > > and I'd think we shouldn't use multicast in test at all (excepts > multicast > > Ip finder self tests of course), > > but e.g. add an assertion to force user to create ipfinder properly. > > > > > > Also, we have a ticket for similar issue in 'examples' module. > > Seems, there are some issues with Platforms module integration. > > Slava, do you think Platforms tests can be fixed as well or one more > ticket > > should be created? > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6826 > > > > On Wed, Dec 5, 2018 at 5:55 PM Denis Mekhanikov <dmekhani...@gmail.com> > > wrote: > > > > > Slava, > > > > > > These are exactly my thoughts, so I fully support you here. > > > I already wrote about it: > > > > > > > http://apache-ignite-developers.2346864.n4.nabble.com/IP-finder-in-tests-td33322.html > > > But I kind of abandoned this activity. Feel free to take over it. > > > > > > Denis > > > > > > ср, 5 дек. 2018 г. в 17:22, Vladimir Ozerov <voze...@gridgain.com>: > > > > > > > Huge +1 > > > > > > > > On Wed, Dec 5, 2018 at 5:09 PM Vyacheslav Daradur < > daradu...@gmail.com> > > > > wrote: > > > > > > > > > Igniters, > > > > > > > > > > I've found that the project's test framework uses > > > > > 'TcpDiscoveryMulticastIpFinder' as default IP finder for tests and > > > > > there are a lot of tests written by Ignite's experts that override > it > > > > > to 'TcpDiscoveryVmIpFinder'. > > > > > > > > > > Most of our tests starting Ignite nodes in the same JVM, that > allows > > > > > us using shared 'TcpDiscoveryVmIpFinder'. > > > > > > > > > > I think that using of 'TcpDiscoveryMulticastIpFinder' may be useful > > > > > only in platforms tests, BTW multi-JVM tests use the tuned > > > > > 'TcpDiscoveryVmIpFinder'. > > > > > > > > > > I see the following main advantages of using > 'TcpDiscoveryVmIpFinder': > > > > > * reducing possible conflicts in the development environment, when > > > > > nodes from different clusters may find each other; > > > > > * speedup of nodes initial discovery, especially on Windows; > > > > > * avoiding of overwriting 'getConfiguration' and copypasta only to > set > > > > > up static IP finder in tests; > > > > > > > > > > So, I'd suggest changing the default IP finder in tests to > > > > > 'TcpDiscoveryVmIpFinder' as the first step and remove related > > > > > boilerplate as the second step. > > > > > > > > > > What do you think? > > > > > > > > > > -- > > > > > Best Regards, Vyacheslav D. > > > > > > > > > > > > > > > > > > -- > > Best regards, > > Andrey V. Mashenkov > > > > -- > Best Regards, Vyacheslav D. >
