Hello! I have indeed committed a fix of TLSv1.3 into master, but I don't think we should rush it in 2.7.5. It is a large change and its implications are not obvious.
It would be much better to merge just the temporary fix int 2.7.5, what is https://issues.apache.org/jira/browse/IGNITE-11860 - which is also ready. It needs not be merged into master. Regards. -- Ilya Kasnacheev чт, 30 мая 2019 г. в 20:00, Dmitriy Pavlov <dpav...@apache.org>: > Ilya K., > > could you please confirm that issue with SSL is fixed now? I saw a > notification from some JIRA. > > Can we proceed with new RC? > > чт, 23 мая 2019 г. в 15:54, Pavel Tupitsyn <ptupit...@apache.org>: > > > -1 (binding) > > > > NuGet packages for Ingite.NET were not built as described in [1]. > > > > This is automated on TeamCity, but was not triggered [2] > > > > [1] https://cwiki.apache.org/confluence/display/IGNITE/Release+Process > > [2] > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages > > > > On Thu, May 23, 2019 at 3:24 PM Andrey Novikov <anovi...@apache.org> > > wrote: > > > > > +1 (binding) > > > > > > 1. Download sources: *OK* > > > 2. Build ignite from sources: *OK* > > > 3. Build Web Console from sources: *OK* > > > 4. Build Web Agent from sources: *OK* > > > > > > On Thu, May 23, 2019 at 6:52 PM Dmitriy Pavlov <dpav...@apache.org> > > wrote: > > > > > > > > Thank you, Nikolay, > > > > > > > > From private discussion with Ilya K.: SSL has a problem and it is > > related > > > > to Java 11. But it is not a regression from 2.7 and SSL is not widely > > > used. > > > > > > > > From private discussion with Ivan P.: Examples cannot be launched > > without > > > > staging repo addition into pom file. Staging is created after RC > > > building, > > > > so it is technically impossible to include staging address into pom > > > before > > > > release. I'll update Release process wiki to explain how to add > staging > > > to > > > > check examples in the RC. It requires manual steps. > > > > > > > > чт, 23 мая 2019 г. в 14:43, Nikolay Izhikov <nizhi...@apache.org>: > > > > > > > > > Looks, much better after script fix: > > > > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/repository/download/ApacheIgniteReleaseJava8_IgniteRelease72CheckFileConsistency/3922167:id/results/result.log > > > > > > > > > > ``` > > > > > --- prev.log 2019-05-23 14:42:02.772020316 +0300 > > > > > +++ cur.log 2019-05-23 14:42:03.128012523 +0300 > > > > > - /apache-ignite-x.x.x-bin/docs/javadoc/javadoc.css > > > > > + /apache-ignite-x.x.x-bin/docs/javadoc/stylesheet.css > > > > > - /apache-ignite-x.x.x-bin/platforms/cpp/docs/arrowdown.png > > > > > - /apache-ignite-x.x.x-bin/platforms/cpp/docs/arrowright.png > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/dir_3ea13a7deaf085a2d3c551dce8b68ff3.html > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/dir_73151ea5884c52b11ec50969c926e1f3.html > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/dir_cabbc57be87e7b42e2aa05a6e528b8d7.html > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/dir_f18fe8b4ea83e72b6c5f9ba3529386ec.html > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/md__data_teamcity_work_88b7ca557be5974_ignite_modules_platforms_cpp_thin-client_README.html > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/md__opt_buildagent_work_efb9561a31f3e585_ignite_modules_platforms_cpp_thin-client_README.html > > > > > + /apache-ignite-x.x.x-bin/platforms/cpp/docs/menudata.js > > > > > + /apache-ignite-x.x.x-bin/platforms/cpp/docs/menu.js > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/structignite_1_1binary_1_1BinaryType_3_01T_01_5_01_4.html > > > > > - > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/structignite_1_1binary_1_1BinaryType_3_01T_01_5_01_4-members.html > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/structignite_1_1binary_1_1BinaryType_3_01T_01_5_4.html > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-bin/platforms/cpp/docs/structignite_1_1binary_1_1BinaryType_3_01T_01_5_4-members.html > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples > > > > > + > /apache-ignite-x.x.x-bin/platforms/python/examples/binary_basics.py > > > > > + > /apache-ignite-x.x.x-bin/platforms/python/examples/create_binary.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/failover.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/get_and_put.py > > > > > + > > /apache-ignite-x.x.x-bin/platforms/python/examples/migrate_binary.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/read_binary.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/readme.md > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/scans.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/sql.py > > > > > + /apache-ignite-x.x.x-bin/platforms/python/examples/type_hints.py > > > > > - /apache-ignite-x.x.x-src/assembly/docfiles/javadoc.css > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-src/modules/core/src/main/java/org/apache/ignite/internal/util/FeatureChecker.java > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-src/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/CheckpointReadLockFailureTest.java > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-src/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/IgniteTcBotInitNewPageTest.java > > > > > + > > > > > > > > > > > /apache-ignite-x.x.x-src/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/db/IndexingMultithreadedLoadContinuousRestartTest.java > > > > > ``` > > > > > > > > > > > > > > > В Чт, 23/05/2019 в 14:05 +0300, Nikolay Izhikov пишет: > > > > > > Seems, compare script doesn't unzip apache-ignite-2.7.0-bin.zip > > file > > > > > before comparsion [1] > > > > > > > > > > > > Seems, our friend 'fabric' term sneaks in download script [2]. > > Step 2 > > > > > > > > > > > > Dmitriy, I think if you fix it and rerun script with proper > > results. > > > > > > > > > > > > ``` > > > > > > #!/usr/bin/env bash > > > > > > set -x > > > > > > > > > > > > > > > > > > mkdir -pv raw/prev > > > > > > cd raw/prev > > > > > > > > > > > > wget > > > > > > > > > > > http://apache-mirror.rbc.ru/pub/apache/ignite/%PREV_IGNITE_VERSION%/apache-ignite-fabric-%PREV_IGNITE_VERSION%-bin.zip > > > > > > #wget > > > > > > > > > > > http://apache-mirror.rbc.ru/pub/apache/ignite/%PREV_IGNITE_VERSION%/apache-ignite-hadoop-%PREV_IGNITE_VERSION%-bin.zip > > > > > > wget > > > > > > > > > > > http://apache-mirror.rbc.ru/pub/apache/ignite/%PREV_IGNITE_VERSION%/apache-ignite-%PREV_IGNITE_VERSION%-src.zip > > > > > > ``` > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3911989&buildTypeId=ApacheIgniteReleaseJava8_IgniteRelease72CheckFileConsistency&tab=buildLog&_focus=644#_state=24,623,669,661 > > > > > > [2] > > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_IgniteRelease72CheckFileConsistency&tab=buildTypeSettings > > > > > > > > > > > > В Чт, 23/05/2019 в 13:20 +0300, Dmitriy Pavlov пишет: > > > > > > > Hi Anton, > > > > > > > > > > > > > > thank you for your attention to details. Could you please check > > the > > > > > reasons > > > > > > > for differences? > > > > > > > > > > > > > > By log, that shows that all objects were added, I can only > > suggest > > > > > there is > > > > > > > a problem in that release step itself. 2.7.5 contains 20 very > > local > > > > > fixes, > > > > > > > it can't generate hugely diff. > > > > > > > > > > > > > > Usually, +1 or -1 indicates if PMC/committer/contributor feels > > > that the > > > > > > > proposed release is better than previous. I'm not sure the > > > > > infrastructure > > > > > > > problem has any effect on the release itself, but, again, thank > > > you for > > > > > > > participation. > > > > > > > > > > > > > > Sincerely, > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > чт, 23 мая 2019 г. в 12:41, Anton Vinogradov <a...@apache.org>: > > > > > > > > > > > > > > > Dmitriy, > > > > > > > > > > > > > > > > This RC can not be released without explanation of huge diff > to > > > > > 2.7.0. > > > > > > > > See my message above. > > > > > > > > So, my -1 (binding). > > > > > > > > > > > > > > > > On Thu, May 23, 2019 at 12:34 PM Nikolay Izhikov < > > > > > nizhi...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > чт, 23 мая 2019 г., 12:28 Dmitriy Pavlov < > dpav...@apache.org > > >: > > > > > > > > > > > > > > > > > > > Hi Denis, > > > > > > > > > > > > > > > > > > > > I don't feel that we have found any blocker. It is > > > impossible to > > > > > do an > > > > > > > > > > absolutely perfect release. (if we do absolutely perfect > > > > > release, what > > > > > > > > > > > > > > > > is > > > > > > > > > > the reason to contribute anything else? :) ) > > > > > > > > > > > > > > > > > > > > The problem now is the only inactivity of PMC members. > > After > > > 4 > > > > > hours I > > > > > > > > > > > > > > > > > > will > > > > > > > > > > close the vote as unsuccessful. > > > > > > > > > > > > > > > > > > > > Having -1 with an explanation of why clearly shows what > can > > > be > > > > > improved > > > > > > > > > > (BTW, thanks to Ilya). Inactivity shows that community > may > > > be not > > > > > > > > > > interested in this release and/or not viable. > > > > > > > > > > > > > > > > > > > > Sincerely, > > > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > > > чт, 23 мая 2019 г. в 05:51, Denis Magda < > > dma...@gridgain.com > > > >: > > > > > > > > > > > > > > > > > > > > > The next Ignite release will go with much more changes > > and > > > > > fixes > > > > > > > > > > > > > > > > > > sitting > > > > > > > > > > in > > > > > > > > > > > the waiting queue while this maintenance release was > > baked > > > for > > > > > > > > > > > > > > > > several > > > > > > > > > > > months. > > > > > > > > > > > > > > > > > > > > > > Dmitriy P. are there any blockers, should we restart > the > > > vote? > > > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wednesday, May 22, 2019, Andrey Gura < > > ag...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Denis, > > > > > > > > > > > > > > > > > > > > > > > > I really don't see any reason for releasing the next > > > Apache > > > > > Ignitie > > > > > > > > > > > > version only for this minor fix. Release process is > > > complex > > > > > enough > > > > > > > > > > > > > > > > > > and > > > > > > > > > > > > it seems that easier way is issue fix and build rc4. > > > > > > > > > > > > > > > > > > > > > > > > Anyway, if we didn't commit about Java 12 support in > > this > > > > > version > > > > > > > > > > > > > > > > so > > > > > > > > > > > > I'm okay with this issue in current build. > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 22, 2019 at 4:20 AM Denis Magda < > > > > > dma...@apache.org> > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Andrey, > > > > > > > > > > > > > > > > > > > > > > > > > > I would encourage us to roll this release out and > > > consider > > > > > this > > > > > > > > > > > > > > > > > > > > change > > > > > > > > > > > > for > > > > > > > > > > > > > the next one. We’re free to make the next release > as > > > soon > > > > > as > > > > > > > > > > > > > > > > > > needed, > > > > > > > > > > > > even a > > > > > > > > > > > > > couple of weeks after. > > > > > > > > > > > > > > > > > > > > > > > > > > Do you agree? > > > > > > > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > On Tuesday, May 21, 2019, Andrey Gura < > > > ag...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Ilya, do you have any estimation for fix Java 12 > > > with SSL > > > > > > > > > > > > > > > > issue? > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, May 21, 2019 at 10:26 PM Denis Magda < > > > > > > > > > > > > > > > > > > dma...@gridgain.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Ignite PMC and committers, please cast your > vote. > > > It's > > > > > time > > > > > > > > > > > > > > > > to > > > > > > > > > > roll > > > > > > > > > > > > the > > > > > > > > > > > > > > release out. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > Denis Magda > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ---------- Forwarded message --------- > > > > > > > > > > > > > > > From: Denis A. Magda <dma...@apache.org> > > > > > > > > > > > > > > > Date: Tue, May 21, 2019 at 7:26 AM > > > > > > > > > > > > > > > Subject: Re: [VOTE] Accept Apache Ignite > > 2.7.5-rc3 > > > > > > > > > > > > > > > To: <dev@ignite.apache.org> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + 1 (binding) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 2019/05/17 13:49:17, Dmitriy Pavlov < > > > > > dpav...@apache.org> > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > Dear Sirs! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > We have uploaded release candidate to > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ignite/2.7.5-rc3/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The following staging can be used for a > > dependent > > > > > project > > > > > > > > > > > > > > > > for > > > > > > > > > > > > testing: > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > orgapacheignite-1438/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is half-release before 2.8 containing > Java > > > 11 > > > > > support > > > > > > > > > > > > > > > > > > and > > > > > > > > > > > > fixes > > > > > > > > > > > > > > for > > > > > > > > > > > > > > > > Native Persistence storage. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Tag name is 2.7.5-rc3: > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite.git;a=tag; > > > > > > > > > > > > > > > > > > > > > > > > > > > > h=refs/tags/2.7.5-rc3 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 2.7.5 changes: > > > > > > > > > > > > > > > > * Added Java 11 support > > > > > > > > > > > > > > > > * Fixed infinite looping during SSL > handshake, > > > > > affecting > > > > > > > > > > > > > > > > Java > > > > > > > > > > > > > > 11/Windows > > > > > > > > > > > > > > > > * Fixed storage corruption case after > > incorrectly > > > > > rotated > > > > > > > > > > > > > > > > > > page > > > > > > > > > > > > > > > > * Erroneous WAL record after incorrectly > > rotated > > > page > > > > > > > > > > > > > > > > > > processed > > > > > > > > > > > > > > > > automatically > > > > > > > > > > > > > > > > * Addressed ignite.sh failure on Mac OS and > > > Linux, > > > > > > > > > > > > > > > > affecting > > > > > > > > > > Java > > > > > > > > > > > > 11 > > > > > > > > > > > > > > > > * Launch scripts and some Ignite > initialization > > > > > steps were > > > > > > > > > > > > > > > > > > > > fixed > > > > > > > > > > > > for > > > > > > > > > > > > > > Java 12 > > > > > > > > > > > > > > > > * Fixed indexes corruption on node stop under > > > load > > > > > > > > > > > > > > > > * Fixed case of node crash during node > > > deactivation > > > > > > > > > > > > > > > > * Error message with advice about required > JVM > > > > > parameters > > > > > > > > > > > > > > > > > > > > printed > > > > > > > > > > > > when > > > > > > > > > > > > > > Java > > > > > > > > > > > > > > > > 9+ is used > > > > > > > > > > > > > > > > * Introduced > SYSTEM_CRITICAL_OPERATION_TIMEOUT > > > > > failure type > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Complete list of closed issues: > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=(project%20% > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 3D%20'Ignite'%20AND%20fixVersion%20in%20('2.7.5')% > > > > > > > > > > > > > > > > > > > > > > > > 20AND%20status%20IN%20( > > > > > > > > > > > > > > > > Resolved%2C%20Closed))%20ORDER%20BY%20priority%20%20% > > > > > > > > > > > > > > 20%20%20%20%20%20%20%20%20%20%20 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > DEVNOTES > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob; > > > > > > > > > > > > > > > > > > > > > > > > > > > > f=DEVNOTES.txt;h=307189059ae70834ead4c127cc1829 > > > > > > > > > > > > > > > > > > > > > > > > 5ce4d0735a;hb=ignite-2.7.5 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > RELEASE NOTES > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob; > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > f=RELEASE_NOTES.txt;h=0a7d2d395b3c9ca1a69ce3f8f16579 > > > > > > > > > > > > > > 40fa12f972;hb=ignite-2.7.5 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The vote is formal, see voting guidelines > > > > > > > > > > > > > > > > > https://www.apache.org/foundation/voting.html > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +1 - to accept Apache Ignite 2.7.5-rc3 > > > > > > > > > > > > > > > > 0 - don't care either way > > > > > > > > > > > > > > > > -1 - DO NOT accept Apache Ignite Ignite > > 2.7.5-rc3 > > > > > (explain > > > > > > > > > > > > > > > > > > why) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This vote will be open for 6 days till May > 23, > > > 14:00 > > > > > UTC. > > > > > > > > > > > > > > > > > > > > > https://www.timeanddate.com/countdown/to?year=2019&month= > > > > > > > > > > > > > > > > > > > > > > > > > > > > 5&day=23&hour=14&min=0&sec=0&p0=utc-1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > - > > > > > > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > -- > > > > > > > > > > > Denis Magda > > > > > > > > > > > > > > > > > > > > > >