Units just can be added to a metric description. What is the purpose of dedicated field for it?
We doesn't provide any API for work with measurement units and should not do it. Metrics interpretation is responsibility of external systems for metrics gathering. Enum with metrics measurement doesn't bring any value for external systems and only useful thing is self documentation. On Wed, Nov 6, 2019 at 12:42 PM Nikolay Izhikov <[email protected]> wrote: > > Hello, Alexey. > > I'm +1. > Let's do it. > > В Ср, 06/11/2019 в 16:37 +0700, Alexey Kuznetsov пишет: > > Hi, All! > > > > I'm working on a tool for metrics monitoring. > > And found that Metric interface [1] has a name and description, but has not > > measurement units. > > > > When you are working on a tool that collects all metrics and shows it in > > human readable format it is a very important piece of information. > > > > Because we have a lot of different metrics, some of them in bytes, some of > > them in percents, some of them are simple counters and so on and so forth. > > > > How about to add Enum with all possible measurement units to Metric > > interface [1] ? > > > > Thoughts? > > > > [1] > > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/spi/metric/Metric.java > >
