I think these metrics are useful. I have prepared PR [1] for commit and rollback histograms. [2] Nikolay, could you take a look, please?
If you do not mind, I will try to add affinity-nodes cache metrics: >> * histograms that measure the time of processing `get`, `put`, `remove`, >> `commit`, `rollback` messages on affinity nodes(primary and backups). Ticket >> doesn't exist for it. I have filed a ticket for it. [3] [1] https://github.com/apache/ignite/pull/7141 [2] https://issues.apache.org/jira/browse/IGNITE-12450 [3] https://issues.apache.org/jira/browse/IGNITE-12453 пн, 16 дек. 2019 г. в 11:07, Alexei Scherbakov <alexey.scherbak...@gmail.com>: > > I think they are very useful. > > пн, 16 дек. 2019 г. в 10:51, Николай Ижиков <nizhi...@apache.org>: > > > Hello, Alexei. > > > > Thanks for the link on the ticket, lableled it with the IEP-35 label. > > What do you think about proposed metrics set? > > > > > 16 дек. 2019 г., в 10:29, Alexei Scherbakov < > > alexey.scherbak...@gmail.com> написал(а): > > > > > > Nikolay, > > > > > > What about batch operations? > > > > > > For messages processing the ticket does exist and even has an > > > implementation from before new metrics API times [1] > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10418 > > > > > > пн, 16 дек. 2019 г. в 10:12, Николай Ижиков <nizhi...@apache.org>: > > > > > >> Hello, Igniters. > > >> > > >> I want to provide the user answers to the following question: "How cache > > >> API operations perform?" > > >> It seems, we need to implements metrics for basic cache API operations > > >> like get, put, remove for it. > > >> > > >> I think we should provide the following metrics: > > >> > > >> * `get`, `put`, `remove` time histograms. Measured for API calls on the > > >> caller node side. > > >> Implemented in [1], commit [2]. > > >> > > >> * `commit`, `rollback` time histograms. Measured for API calls on the > > >> caller node side [3]. > > >> > > >> * histograms that measure the time of processing `get`, `put`, `remove`, > > >> `commit`, `rollback` messages on affinity nodes(primary and backups). > > >> Ticket doesn't exist for it. > > >> > > >> What do you think? > > >> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-12219 > > >> [2] > > >> > > https://github.com/apache/ignite/commit/e66bbef97b2cef73a533ce8a506ec479852cb364 > > >> [3] https://issues.apache.org/jira/browse/IGNITE-12450 > > >> > > > > > > > > > -- > > > > > > Best regards, > > > Alexei Scherbakov > > > > > > -- > > Best regards, > Alexei Scherbakov -- Best wishes, Amelchev Nikita
