Hi all! I do believe being able to execute some AWS integration tests on demand would be of value, especially for reviewers who cannot have an AWS stack created on demand. More than happy to help on that.
Kind regards *Emmanouil Gkatziouras* https://egkatzioura.com/ | https://www.linkedin.com/in/gkatziourasemmanouil/ https://github.com/gkatzioura On Fri, 24 Jan 2020 at 15:15, Sergey Chugunov <sergey.chugu...@gmail.com> wrote: > Hello Emmanouil, > > It would be great if we have at least basic integration tests in real AWS > environment. Even though they may require more work to keep them green (I > mean here AWS quotas and additional configuration/reconfiguration efforts) > it worth it because these tests can also be useful as an examples. > > As the same time as IpFinder is such a basic component I don't think we > need to include them in constantly triggered suites like Run All but to > trigger them manually before/right after merging them to master branch or > when developing something in related code. > > What do you think? > > -- > Thank you, > Sergey Chugunov. > > On Thu, Jan 23, 2020 at 5:32 PM Emmanouil Gkatziouras < > gkatzio...@gmail.com> > wrote: > > > Hi all! > > > > Yes It seems possible to get some free quota for integration tests on AWS > > [1] however most probably they are not gonna last forever. > > > > [1] > > > > > https://aws.amazon.com/blogs/opensource/aws-promotional-credits-open-source-projects/ > > > > King Regards > > *Emmanouil Gkatziouras* > > https://egkatzioura.com/ | > > https://www.linkedin.com/in/gkatziourasemmanouil/ > > https://github.com/gkatzioura > > > > > > On Wed, 22 Jan 2020 at 16:48, Denis Magda <dma...@apache.org> wrote: > > > > > Hi Emmanouil, > > > > > > Thanks for preparing a pull-request for Application Load Balancer: > > > https://issues.apache.org/jira/browse/IGNITE-8617 > > > > > > Igniters, who is willing to step in as a primary reviewer? > > > > > > As for automated testing on AWS, are you aware of any sponsorship > program > > > of AWS for open source projects of our kind? It will be ideal to have > > real > > > testing on AWS but someone needs to pay. > > > > > > - > > > Denis > > > > > > > > > On Sun, Jan 19, 2020 at 6:45 AM Emmanouil Gkatziouras < > > > gkatzio...@gmail.com> > > > wrote: > > > > > > > Hi all! > > > > > > > > I have spinned up an Application Load Balancer and an autoscaling > group > > > on > > > > AWS and the Ignite discovery using TcpDiscoveryAlbIpFinder works as > > > > expected. > > > > > > > > - On startup nodes discover each other. > > > > - On ec2 node down, connection is lost and the cluster decreases. > > > > - On an extra node addition the cluster size increases > > > > > > > > This contribution is essential since the Previous ELB based discovery > > > uses > > > > the Classic Load Balancer which is still available however > > > > AWS advices users to use the Application one. [1] > > > > While my pull request gets reviewed I will also have a look at > > > > the IGNITE-12398 [2] issue which has to do with the S3 discovery. > > > > Another idea would also be to implement a `TCP Load Balancer based` > > > > discovery. > > > > > > > > In order to test this issue and future ones I implemented some > > terraform > > > > scripts (which I shall use for other issues too) [3]. > > > > If some automated e2e testing on AWS is being considered they might > be > > of > > > > value. > > > > I can help on implementing those tests by provisioning the > > infrastructure > > > > in an automated way and validate the discovery. > > > > > > > > [1] > > > > > > > > > > > > > > https://docs.aws.amazon.com/elasticloadbalancing/latest/userguide/migrate-to-application-load-balancer.html > > > > [2] https://issues.apache.org/jira/browse/IGNITE-12398 > > > > [3] https://github.com/gkatzioura/ignite-aws-deploy > > > > > > > > Kind regards, > > > > *Emmanouil Gkatziouras* > > > > https://egkatzioura.com/ | > > > > https://www.linkedin.com/in/gkatziourasemmanouil/ > > > > https://github.com/gkatzioura > > > > > > > > > > > > On Tue, 14 Jan 2020 at 22:22, Denis Magda <dma...@apache.org> wrote: > > > > > > > > > Hi Emmanouil, > > > > > > > > > > Agree, let's check that the IP finder functions normally in the > cloud > > > > > environment and the mock tests can be used for regular testing on > > Team > > > > > City. That's the way we tested other environment-specific IP > finders > > > > > including the Kubernetes one. > > > > > > > > > > Let us know once the IP finder is tested on AWS and then we can > > proceed > > > > > with the review. > > > > > > > > > > - > > > > > Denis > > > > > > > > > > > > > > > On Tue, Jan 14, 2020 at 2:47 AM Emmanouil Gkatziouras < > > > > > gkatzio...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hi all! > > > > > > > > > > > > With regards to the `Node Discovery Using AWS Application ELB` > > issue > > > > [1] > > > > > > I made this pull request to fix the merge conflicts [2]. > > > > > > Will also check if the concerns described on the mailing list > topic > > > > > > `Volunteer needed: AWS Elastic Load Balancer IP Finders > > implemented` > > > > are > > > > > > addressed [3] > > > > > > Since I did not test it on an AWS infrastructure the next step > > would > > > be > > > > > to > > > > > > spin up some AWS resources and test it. > > > > > > By doing so it will help me on checking the Amazon S3 Based > > Discovery > > > > > issue > > > > > > [4] . > > > > > > I will try to make the deployment as infrastructure as code, and > > see > > > if > > > > > > this can be of value for the ignite project and testing. > > > > > > > > > > > > Kind regards, > > > > > > Emmanouil > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-8617 > > > > > > [2] https://github.com/apache/ignite/pull/7247 > > > > > > [3] > > > > > > > > > > > > > > > > > > > > > > > > > > > http://apache-ignite-developers.2346864.n4.nabble.com/Volunteer-needed-AWS-Elastic-Load-Balancer-IP-Finders-implemented-td33847.html#a39793 > > > > > > [4] https://issues.apache.org/jira/browse/IGNITE-12398 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
