Vladimir, In current implementation the flag does not change if data is kept or cleared from memory - after deactivation the internal structures are cleared and only data region is kept allocated. If you add a validation for this flag, you forbid users to do a rolling cluster restart and enable/disable this behavior without full cluster restart, which itself means total data loss in case of an in-memory cluster.
Same stands for all other system properties. Unless the property is absolutely required to be the same on all nodes, there is no need to validate, this makes the cluster configuration rigid; such properties may be changed only with the whole cluster downtime. ср, 5 февр. 2020 г. в 18:40, Maxim Muzafarov <mmu...@apache.org>: > Folks, > > > I think it's a common problem for such system properties (which may be > different on different nodes and which may lead to unpredictable > cluster behaviour). The same mentioned by Ivan here [1]. > > Is it better to validate (somehow) all system properties, for > instance, started with IGNITE_ prefix, on all nodes the same way as we > do it for IgniteConfiguration? > > [1] > https://issues.apache.org/jira/browse/IGNITE-12470?focusedCommentId=17004207&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17004207 > > On Wed, 5 Feb 2020 at 17:20, Nikolay Izhikov <nizhi...@apache.org> wrote: > > > > Vladimir. > > > > This looks like a bug to me. > > > > Can you, please, prepare the simple reproducer for this issue and it’s > consequences? > > > > > > > 5 февр. 2020 г., в 17:08, Vladimir Steshin <vlads...@gmail.com> > написал(а): > > > > > > Hi, folks. > > > > > > > > > > > > I recently found that one node might be started with flag > > > reuse-memory-on-deactivate [1] set off while another node might be > > > configured with the flag enabled. This ability hinders prediction of > > > cluster behavior on deactivation/activation. One node keeps data in > memory, > > > other doesn’t. > > > > > > Should we check this flag is set equally on all nodes? Is this an > issue? We > > > might prevent node start if it has different setting. > > > > > > > > > > > > [1] IgniteSystemProperties#IGNITE_REUSE_MEMORY_ON_DEACTIVATE > > >
