Hi Mikhail, Thank you in you help with this! I left some comments in JIRA [1].
[1] https://issues.apache.org/jira/browse/IGNITE-12976 Best regards, Ivan Pavlukhin вс, 10 мая 2020 г. в 10:49, Denis Magda <dma...@apache.org>: > > Hi Mikhail, > > Thanks for taking care of this. Please check JIRA. Changes look good to me > but I would add a test to ensure that issue doesn't bubble up in the future. > > - > Denis > > > On Sun, May 10, 2020 at 12:33 AM Mikhail Kostyuckovich < > m.kostyuckov...@irdeto.com> wrote: > > > Hello Ignite Developers, > > > > > > I have prepared a small PR fixing the following issue related to Spring > > Data integration: > > > > IGNITE-12976: Invalid SQL syntax for NULLS LAST / NULLS FIRST in > > IgniteQueryGenerator > > https://issues.apache.org/jira/browse/IGNITE-12976 > > > > > > Could you please have a look and approve/accept? > > https://github.com/apache/ignite/pull/7766 > > > > Many thanks in advance! > > > > > > Kind regards, > > Mikhail Kostyuckovich > >
