Why does the control.sh use JVM_OPTS in the first place? Is there a case when a user might need to modify them? I can't think of one.
-Val On Thu, Sep 24, 2020 at 6:42 AM Evgenii Zhuravlev <e.zhuravlev...@gmail.com> wrote: > Ilya, > > You can get absolutely the same behaviour when you set JVM_OPTS even > without Docker. > > Evgenii > > чт, 24 сент. 2020 г. в 05:44, Ilya Kasnacheev <ilya.kasnach...@gmail.com>: > > > Hello! > > > > If the issue is with docker only, then maybe we should get rid of > JVM_OPTS > > with docker entirely? E.g. pass them as parameters. > > > > I'm not sold on this change yet, it breaks backward compatibility for > > marginal benefit. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > чт, 24 сент. 2020 г. в 15:35, Данилов Семён <samvi...@yandex.ru>: > > > > > Hello, Igniters! > > > > > > I recently discovered, that control.sh and ignite.sh both use JVM_OPTS > > > environment variable. This can lead to various issues (especially in > > > docker), such as: > > > * Control utility will have the same xms/xmx parameters. > > > * Control utility won't launch due to JMX port being in use (as it is > set > > > in JVM_OPTS and already occupied by ignite). > > > And so on. > > > > > > I suggest using different environment variable in control.sh > > > (CONTROL_JVM_OPTS for example). > > > > > > Here is the JIRA issue — > > > https://issues.apache.org/jira/browse/IGNITE-13479 > > > And a pull request — https://github.com/apache/ignite/pull/8275/ > > > > > > Regards, Semyon. > > > > > >
