Sergey, thank you, no further comments on the public API changes from my side. We certainly need more eyes on this, though - I can't do a full review since I'm not very familiar with this area.
On Fri, Oct 9, 2020 at 3:49 PM Sergey Chugunov <sergey.chugu...@gmail.com> wrote: > Hi Pavel, > > Thanks, I looked through your comments and fixed them. Could you please > check one more time? > > On Fri, Oct 9, 2020 at 10:27 AM Pavel Tupitsyn <ptupit...@apache.org> > wrote: > > > Hello Sergey, > > > > I went over the public API changes briefly and left some minor comments > on > > GitHub > > > > Thanks, > > Pavel > > > > On Fri, Oct 9, 2020 at 9:59 AM Sergey Chugunov < > sergey.chugu...@gmail.com> > > wrote: > > > > > Hello Igniters, > > > > > > I'm getting closer to finishing main ticket for Maintenance Mode > feature > > > [1] and now working on test fixes (most likely test modifications are > > > needed). > > > > > > So I would like to ask for a review of my pull request [2] to discuss > the > > > code earlier. Test status is pretty good so I expect to get a green > visa > > > soon. > > > > > > Could you please take a look? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-13366 > > > [2] https://github.com/apache/ignite/pull/8325 > > > > > >
