Hi Michael, Denis I did an initial review of the PR and wanted to share my thoughts. I observed that currently the implementation is using Ignite messaging apis and I am thinking if we should change the implementation to use Ignite data streaming apis. The reason for change is to ensure that it will be better aligned to Ignite 3.0 release as we are planning to deprecate Ignite Messaging apis in Ignite 3.0 [1]
My recommendation to use Ignite data streaming apis is also due to the fact that we have multiple integration like Google Pub/Sub[2] and Kafka Streamer[3] that uses Data streaming apis for integration and it will keep micronaut implementation consistent with other extensions. Here is an example[4] of how Kafka Streamer can be used to stream data into Ignite nodes. [1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0 [2] https://github.com/apache/ignite-extensions/blob/master/modules/pub-sub-ext/src/main/java/org/apache/ignite/stream/pubsub/PubSubStreamer.java [3] https://github.com/apache/ignite-extensions/blob/master/modules/kafka-ext/src/main/java/org/apache/ignite/stream/kafka/KafkaStreamer.java [4] https://github.com/samaitra/streamersk-extensions/blob/main/src/main/kotlin/com/example/streamerskextensions/kafka/KafkaStreamer.kt Please let me know your feedback. Regards, Saikat On Tue, Oct 27, 2020 at 12:48 PM Denis Magda <dma...@apache.org> wrote: > Michael, glad to see you back! > > Could you please explain in a few words what this integration does and what > it enables for Ignite and Micronaout? So that we are as a community are on > the same page. > > - > Denis > > > On Sun, Oct 25, 2020 at 3:05 PM Michael Pollind <mpoll...@gmail.com> > wrote: > > > I've started to work on adding some basic pubsub support for > > Micronaut-ignite. I only have a draft PR in progress. There are a couple > > modules that already implement pub-sub so those modules would be a good > > start for reference: > > https://github.com/micronaut-projects/micronaut-gcp > > https://github.com/micronaut-projects/micronaut-kafka > > https://github.com/micronaut-projects/micronaut-mqtt > > > > https://github.com/micronaut-projects/micronaut-ignite/pull/62 > > > > > > >
