Hi, As discussed I have updated the PR https://github.com/apache/ignite-extensions/pull/30
Please review and share your feedback. Regards, Saikat On Mon, Nov 9, 2020 at 6:38 PM Saikat Maitra <[email protected]> wrote: > Hi Nikolay, > > Thank you for reviewing the changes. I have made changes only in the > README.txt file and updated the artifactId so that it matches with pom.xml. > > I have also updated the version details in the PR so that it matches with > our release version. > > https://github.com/apache/ignite-extensions/pull/30 > > With respect to naming convention I was thinking we would not be required > to change the groupId and we will only change the artifactId similar to > spring-boot-autoconfigure-ext module. > > > https://github.com/apache/ignite-extensions/blob/master/modules/spring-boot-autoconfigure-ext/pom.xml#L33 > > Please review and let me know your thoughts. > > Regards, > Saikat > > > > > On Mon, Nov 9, 2020 at 12:32 AM Nikolay Izhikov <[email protected]> > wrote: > >> Hello, Saikat. >> >> As far as I can see you changed artifactId of the extensions not only >> docs. >> >> Do we have an agreement to name each extension as «{extension-name}-ext» >> like «ignite-camel-ext» or similar? >> We don’t have much extensions release, so maybe it will be better to have >> naming like >> >> groupId=org.apache.ignite.extensions >> artifactId=ignite-camel >> >> What do you think? >> >> >> > 9 нояб. 2020 г., в 05:36, Saikat Maitra <[email protected]> >> написал(а): >> > >> > Hi, >> > >> > I have raised a PR for the following issue. >> > >> > Jira : https://issues.apache.org/jira/browse/IGNITE-12951 >> > PR : https://github.com/apache/ignite-extensions/pull/30 >> > >> > This is an initial PR in Ignite Extensions repo. I will work on another >> PR >> > in ignite repo for the remaining changes. >> > >> > Regards, >> > Saikat >> >>
