+1 (binding). Reverting my previous -1. We agreed that the release won't be announced and referenced from the website until the docs are ready.
Yaroslav, could you please help to prepare the tickets and put together a draft? Nikita, thanks a lot for stepping up and agreeing to help with the review! - Denis On Wed, Dec 16, 2020 at 10:12 AM Yaroslav Molochkov <molochko...@gmail.com> wrote: > Hello everyone! > > Yeah, guys, sorry, absolutely my mishap with docs. > > Denis, of course, i will see to it that docs are ready first and foremost. > > On Wed, Dec 16, 2020 at 8:30 PM Denis Magda <dma...@apache.org> wrote: > > > Hi Maxim, > > > > Ignite 2.9 docs were completed by the time we were running a vote for the > > last release candidate. Once the vote passed, I released the docs through > > the website. What happened next is an ongoing process of keeping the docs > > actual - addressing users' feedback, merging generic changes to the > master > > and the latest release branch, etc. > > > > Anyway, speaking about 2.9.1. This is, in fact, a release blocker. > > Otherwise, I wouldn't have cast the -1 vote. We're doing those features > for > > application developers who shouldn't consult with the Ignite source > > codebase on how to leverage the new capabilities. > > > > But, I hear you. Let's make an exception this time, considering a small > > number of documentation tasks. As the community, I do believe that we > will > > eventually develop a habit of preparing all necessary changes by the > time a > > vote starts. So, do we agree that the release won't be announced, and > > binaries won't be referenced from the website until the docs are ready? > My > > guess the docs might be ready this or early next week. > > > > - > > Denis > > > > > > On Wed, Dec 16, 2020 at 7:00 AM Maxim Muzafarov <mmu...@apache.org> > wrote: > > > > > Denis, > > > > > > I remember the agreement, but also we are always fixing documentation > > > pages even after a release announced (like for 2.9.0 and the > > > ignite-2.9 release branch). Can we go the same way here? For instance, > > > we can add all necessary documentation pages prior to the 2.9.1 wide > > > announce. > > > > > > It doesn't seem to be the release blocker here, as the same as the > > > checkstyle issues weren't for 2.9.0. Isn't it? > > > > > > On Wed, 16 Dec 2020 at 17:14, Denis Magda <dma...@apache.org> wrote: > > > > > > > > Yaroslav, thanks for checking, > > > > > > > > - 1 (binding) - I have to cast this vote as long as the docs need to > be > > > > ready by the time of the vote. > > > > > > > > Yaroslav, could you please help to prepare a draft with the > > documentation > > > > updates? Nikita, would you mind reviewing the changes? > > > > > > > > Denis > > > > > > > > On Wednesday, December 16, 2020, Yaroslav Molochkov < > > > molochko...@gmail.com> > > > > wrote: > > > > > > > > > Denis, actually, i'm mistaken, totally forgot about these: > > > > > * Added System view for binary metadata > > > > > * Added System view for metastorage items > > > > > * Added RebalancingPartitionsTotal metrics > > > > > > > > > > On Wed, Dec 16, 2020 at 1:03 PM Yaroslav Molochkov < > > > molochko...@gmail.com> > > > > > wrote: > > > > > > > > > > > Denis, hello! > > > > > > > > > > > > Since it's a minor bug-fixing release the update is not needed > > > > > > > > > > > > On Tue, Dec 15, 2020 at 9:38 PM Denis Magda <dma...@apache.org> > > > wrote: > > > > > > > > > > > >> Hi Yaroslav, > > > > > >> > > > > > >> Do we need to update documentation? > > > > > >> > > > > > >> - > > > > > >> Denis > > > > > >> > > > > > >> > > > > > >> On Mon, Dec 14, 2020 at 11:34 PM Yaroslav Molochkov < > > > > > >> molochko...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > >> > Dear Community, > > > > > >> > > > > > > >> > I have uploaded release candidate to > > > > > >> > https://dist.apache.org/repos/dist/dev/ignite/2.9.1-rc1/ > > > > > >> > > > https://dist.apache.org/repos/dist/dev/ignite/packages_2.9.1-rc1/ > > > > > >> > > > > > > >> > The following staging can be used for testing: > > > > > >> > > > > > > >> https://repository.apache.org/content/repositories/ > > > > > orgapacheignite-1490/ > > > > > >> > > > > > > >> > Tag name is 2.9.1-rc1: > > > > > >> > > > > > > >> > > > > > > >> https://gitbox.apache.org/repos/asf?p=ignite.git;a=tag; > > > > > h=refs/tags/2.9.1-rc1 > > > > > >> > > > > > > >> > 2.9.1 changes: > > > > > >> > * Added support to graceful shutdown for ZookeeperDiscoverySpi > > > > > >> > * Added System view for binary metadata > > > > > >> > * Added System view for metastorage items > > > > > >> > * Added RebalancingPartitionsTotal metrics > > > > > >> > * Improved checkpoint concurrent behaviour > > > > > >> > * Fixed critical system error when unregister a JMX bean > > > > > >> > * Fixed IgniteCache#isClosed() returns false on server node > even > > > if > > > > > the > > > > > >> > cache had been closed before > > > > > >> > * Fixed inability to eagerly remove expired cache entries > > > > > >> > * Fixed partial index rebuild issue in case indexed cache > > contains > > > > > >> > different datatypes > > > > > >> > * Fixed local metastorage system view error if unmarshallable > > > values > > > > > >> > present > > > > > >> > * Fixed deadlock between grid-timeout-worker and a thread > > opening > > > a > > > > > >> > communication connection > > > > > >> > * Fixed deadlock in IgniteServiceProcessor > > > > > >> > * Fixed issue when rebalance future might hang in no final > state > > > > > though > > > > > >> all > > > > > >> > partitions are owned > > > > > >> > * Fixed issue when scan query fails with an assertion error: > > > > > Unexpected > > > > > >> row > > > > > >> > key > > > > > >> > * Fixed issue with archiving and enabled wal compaction > setting > > on > > > > > >> server > > > > > >> > restart > > > > > >> > * Fixed NPE during Cassandra Store initialization with > PRIMITIVE > > > > > >> strategy > > > > > >> > * Fixed synchronization problems when different classloaders > are > > > used > > > > > >> for > > > > > >> > deployment of same class > > > > > >> > * Fixed exception on SQL caches when client reconnect > > > > > >> > * Fixed deadlock on multiple cache delete > > > > > >> > * Fixed NPE in IgniteServiceProcessor when destroying a cache > > > > > >> > * Fixed issue when DurableBackgroundTask can abandon > incomplete > > > task > > > > > >> > * Fixed issue related to cache interceptor deserialization on > > > client > > > > > >> nodes > > > > > >> > * Fixed issue when control.sh doesn't start if JMX port was > set > > > > > >> > * Fixed issue when > ZookeeperDiscoverySpiMBeanImpl#getCoordinator > > > can > > > > > >> return > > > > > >> > invalid node as coordinator > > > > > >> > * Fixed issue when valid blocking section in GridNioWorker and > > > > > >> > GridNioClientWorker leads to false positive blocking thread > > > detection > > > > > >> > * Fixed several logging issues > > > > > >> > * Fixed issue when exchange worker, waiting for new task from > > > queue, > > > > > >> > considered as blocked > > > > > >> > * Fixed incorrect topology snapshot logger output about > > > coordinator > > > > > >> change > > > > > >> > * Fixed slowdown during node initialization > > > > > >> > * Fixed incorrect usage of Class.isAssignableFrom in > > > SystemViewLocal > > > > > and > > > > > >> > SystemViewMBean classes > > > > > >> > * Fixed several concurrent metrics issues > > > > > >> > * Fixed issue related to incorrect work of predicates (< and > >) > > in > > > > > where > > > > > >> > clause with compound primary key > > > > > >> > * Removed unnecessary dependency to curator-client from and > > > improved > > > > > >> > ZookeeperDiscoverySpi > > > > > >> > * Removed unnecessary failure trace in IgnitionEx > > > > > >> > * Fixed issue when thin client connect/disconnect during > > topology > > > > > update > > > > > >> > may lead to partition divergence in ignite-sys-cache > > > > > >> > * Fixed issue when thin client silently closes channel after > > > > > inactivity > > > > > >> > * Fixed unsupported protocol version exception when getting > > cache > > > > > >> > configuration from Java thin client > > > > > >> > * Fixed thin driver reports incorrect property names > > > > > >> > * Updated JDBC metadata to match actual capabilities > > > > > >> > * Improved slow Enum serialization > > > > > >> > * Fixed issue when deserializing IBinaryObject containing an > > > > > >> IBinaryObject > > > > > >> > field fails > > > > > >> > * Fixed issue TransactionImpl finalizer can crash the process > > > > > >> > * Fixed child processes become zombies when persistence is > used > > > with > > > > > >> > direct-io on Linux > > > > > >> > * Added Windows support to CMake build system > > > > > >> > * Fixed issue when odbc-example loses values if run with 1 > > > additional > > > > > >> node > > > > > >> > > > > > > >> > RELEASE NOTES: > > > > > >> > > > > > > >> > > > > > > >> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob; > > > > > f=RELEASE_NOTES.txt;hb=ignite-2.9.1 > > > > > >> > > > > > > >> > Complete list of resolved issues: > > > > > >> > > > > > > >> > > > > > > >> https://issues.apache.org/jira/browse/IGNITE-13770?jql= > > > > > project%20%3D%20IGNITE%20AND%20status%20in%20(Resolved%2C% > > > > > 20Closed)%20AND%20fixVersion%20%3D%202.9.1 > > > > > >> > > > > > > >> > DEVNOTES > > > > > >> > > > > > > >> > > > > > > >> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob_ > > > > > plain;f=DEVNOTES.txt;hb=ignite-2.9.1 > > > > > >> > > > > > > >> > The vote is formal, see voting guidelines > > > > > >> > https://www.apache.org/foundation/voting.html > > > > > >> > > > > > > >> > +1 - to accept Apache Ignite 2.9.1-rc1 > > > > > >> > 0 - don't care either way > > > > > >> > -1 - DO NOT accept Apache Ignite Ignite 2.9.1-rc1 (explain > why) > > > > > >> > > > > > > >> > See notes on how to verify release here > > > > > >> > https://www.apache.org/info/verification.html > > > > > >> > and > > > > > >> > > > > > > >> > > > > > > >> > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process# > > > > > ReleaseProcess-P5.VotingonReleaseandReleaseVerification > > > > > >> > > > > > > >> > This vote will be open for at least 3 days till Fri Dec 18, > > 10:30 > > > am > > > > > >> UTC. > > > > > >> > > > > > > >> > > > > > > >> https://www.timeanddate.com/countdown/generic?iso= > > > > > 20201218T1030&p0=166&font=cursive > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > -- > > > > - > > > > Denis > > > > > >
