Hi, guys. I have prepared PR to fix module names [1, 2]. Could you take a look and recheck TC integration, please?
Note that module names in TC suites should be changed as well. [1] https://github.com/apache/ignite-extensions/pull/58 [2] https://issues.apache.org/jira/browse/IGNITE-14621 чт, 22 апр. 2021 г. в 00:08, Nikita Amelchev <namelc...@apache.org>: > > I have created the issue to fix modules names: > > https://issues.apache.org/jira/browse/IGNITE-14621 > > ср, 21 апр. 2021 г. в 11:46, Nikita Amelchev <namelc...@apache.org>: > > > > +1 to formalize extension modules names: > > ignite-{directory-name} > > > > The release script has this issue too. It will work fine with that name. > > > > ср, 21 апр. 2021 г. в 10:37, Petr Ivanov <mr.wei...@gmail.com>: > > > > > > I checked the modules and there is misnaming issue which I think is > > > critical to test integration automation on TC. > > > Can we change maven module names sping-data-2.x-ext to align with > > > directory name? Currently there is underscore in maven module name, which > > > is hyphen in directory name. > > > > > > > > > > On 21 Apr 2021, at 10:22, Nikita Amelchev <namelc...@apache.org> wrote: > > > > > > > > +1 to postpone the spring-tx-ext extension release. > > > > > > > > So, the following extensions will be released now: > > > > > > > > spring-data-ext > > > > spring-data-2.0-ext > > > > spring-data-2.2-ext > > > > spring-data-commons > > > > performance-statistics-ext > > > > > > > > вт, 20 апр. 2021 г. в 14:49, Mikhail Petrov <pmgheap....@gmail.com>: > > > >> > > > >> Igniters, > > > >> > > > >> Changing the scope of Spring dependencies to "provided" in Ignite > > > >> Spring > > > >> extensions does not currently work as expected: > > > >> some versions of Spring that a user can specify via maven configuration > > > >> for Spring extensions may conflict with the hard-coded version of > > > >> Spring > > > >> dependencies that the ignite-spring module relies on. > > > >> > > > >> The issue mentioned above affects the Ignite Spring Transactions > > > >> integration. And since this integration is included in the Ignite 2.10 > > > >> release, I suggest postponing the release of the Ignite Spring > > > >> Transactions integration until the above issue is properly fixed. > > > >> > > > >> Any objections? > > > >> > > > >> On 16.04.2021 09:15, Ivan Daschinsky wrote: > > > >>> -1 From me. There is an absence of NOTICE and LICENSE files in binary > > > >>> package. Also, there is no source package. These is a violation of > > > >>> apache > > > >>> release policy [1] > > > >>> [1] https://www.apache.org/legal/release-policy.html > > > >>> > > > >>> чт, 15 апр. 2021 г. в 23:23, Nikita Amelchev <namelc...@apache.org>: > > > >>> > > > >>>> According to ASF release policy [1] non-PMC committers can sign > > > >>>> artifacts: > > > >>>> > > > >>>>> all artifacts placed in their directory must be signed by a > > > >>>>> committer, > > > >>>> preferably by a PMC member. > > > >>>> > > > >>>> [1] https://www.apache.org/legal/release-policy.html > > > >>>> > > > >>>> чт, 15 апр. 2021 г. в 23:05, Dmitriy Pavlov <dpav...@apache.org>: > > > >>>>> My best guess that since PMCs have a binding vote in voting in > > > >>>>> release, a > > > >>>>> PMC member should sign binaries as well. And I suppose that in the > > > >>>>> past > > > >>>>> only PMC members were signing the release. > > > >>>>> > > > >>>>> Meanwhile, https://infra.apache.org/release-signing.html does not > > > >>>> contain > > > >>>>> any mention of PMC role and only committers are mentioned there. It > > > >>>>> might be not an answer, since a lot of projects have PMC=Committer > > > >>>>> and > > > >>>> just > > > >>>>> one election. > > > >>>>> > > > >>>>> Sincerely, > > > >>>>> Dmitriy Pavlov > > > >>>>> > > > >>>>> чт, 15 апр. 2021 г. в 22:05, Ivan Daschinsky <ivanda...@gmail.com>: > > > >>>>> > > > >>>>>> I'm sorry, but is it OK, that artifacts are signed with signature > > > >>>>>> of > > > >>>>>> non-PMC? > > > >>>>>> > > > >>>>>> чт, 15 апр. 2021 г. в 19:26, Nikita Amelchev > > > >>>>>> <namelc...@apache.org>: > > > >>>>>> > > > >>>>>>> Dear Ignite Community, > > > >>>>>>> > > > >>>>>>> I have uploaded a release candidate of the following extension > > > >>>> modules: > > > >>>>>>> performance-statistics-ext > > > >>>>>>> spring-data-ext > > > >>>>>>> spring-data-2.0-ext > > > >>>>>>> spring-data-2.2-ext > > > >>>>>>> spring-data-commons > > > >>>>>>> spring-tx-ext > > > >>>>>>> > > > >>>>>>> The release candidate of the performance-statistics-ext extension: > > > >>>>>>> > > > >>>>>>> > > > >>>> https://dist.apache.org/repos/dist/dev/ignite/ignite-performance-statistics-ext/1.0.0-rc1/ > > > >>>>>>> The following staging can be used for testing: > > > >>>>>>> > > > >>>> https://repository.apache.org/content/repositories/orgapacheignite-1509 > > > >>>>>>> Tags were created: > > > >>>>>>> > > > >>>>>>> ignite-performance-statistics-ext-1.0.0-rc1 > > > >>>>>>> > > > >>>>>>> > > > >>>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=b992d9758278c38e93b375b08e4052954744a436 > > > >>>>>>> ignite-spring-data-ext-1.0.0-rc1 > > > >>>>>>> ignite-spring-data-2.2-ext-1.0.0-rc1 > > > >>>>>>> ignite-spring-data-2.0-ext-1.0.0-rc1 > > > >>>>>>> ignite-spring-data-commons-1.0.0-rc1 > > > >>>>>>> ignite-spring-data-all-ext-1.0.0-rc1 > > > >>>>>>> > > > >>>>>>> > > > >>>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=277ca95f6472d8bd46d906e70ba1a312d36dadb0 > > > >>>>>>> ignite-spring-tx-ext-1.0.0-rc1 > > > >>>>>>> > > > >>>>>>> > > > >>>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=55a3ae9e011ba48796847a33481842f154f0febb > > > >>>>>>> RELEASE NOTES: > > > >>>>>>> > > > >>>>>>> > > > >>>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb > > > >>>>>>> DOCUMENTATION: > > > >>>>>>> Documentation of listed extensions was updated in the following > > > >>>> issues: > > > >>>>>>> > > > >>>> https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14417%2CIGNITE-14398%2CIGNITE-14397%2CIGNITE-14493) > > > >>>>>>> The vote is formal, see voting guidelines > > > >>>>>>> https://www.apache.org/foundation/voting.html > > > >>>>>>> > > > >>>>>>> +1 - to accept all the Apache Ignite performance-statistics-ext, > > > >>>>>>> spring-data-all-ext and spring-tx-ext extensions 1.0.0-rc1 listed > > > >>>>>>> in > > > >>>>>>> the thread > > > >>>>>>> 0 - don't care either way > > > >>>>>>> -1 - DO NOT accept either of the Apache Ignite > > > >>>>>>> performance-statistics-ext, spring-data-all-ext and spring-tx-ext > > > >>>>>>> extensions 1.0.0-rc1 (explain why) > > > >>>>>>> > > > >>>>>>> The vote will hold for 72 hours and will end on April 18 2021 > > > >>>>>>> 17:00 > > > >>>> UTC > > > >>>>>>> > > > >>>> https://www.timeanddate.com/countdown/generic?iso=20210418T17&p0=1440&font=cursive > > > >>>>>>> -- > > > >>>>>>> Best wishes, > > > >>>>>>> Amelchev Nikita > > > >>>>>>> > > > >>>>>> > > > >>>>>> -- > > > >>>>>> Sincerely yours, Ivan Daschinskiy > > > >>>>>> > > > >>>> > > > >>>> > > > >>>> -- > > > >>>> Best wishes, > > > >>>> Amelchev Nikita > > > >>>> > > > >>> > > > > > > > > > > > > > > > > -- > > > > Best wishes, > > > > Amelchev Nikita > > > > > > > > > -- > > Best wishes, > > Amelchev Nikita > > > > -- > Best wishes, > Amelchev Nikita -- Best wishes, Amelchev Nikita
