You’re right, it’s documented and works as described. My bad.

> On 18 Jun 2021, at 11:24, Igor Sapego <isap...@apache.org> wrote:
> 
> Well,
> 
> This behaviour maybe is not obvious, but it seems to be safe and
> should not cause user issues. On the other hand, if we change this
> behavior now, it may lead to implicit disable of SSL for users that
> updated their client which seems more dangerous to me.
> 
> So I'd keep the current behaviour.
> 
> Best Regards,
> Igor
> 
> 
> On Fri, Jun 18, 2021 at 1:17 PM Ivan Daschinsky <ivanda...@gmail.com> wrote:
> 
>> I suppose that we should not cancel this release, despite the fact that
>> this is not obvious behaviour. This is not a regression, this behaviour is
>> documented and this behaviour lasts for few years. Lets remove it, if the
>> majority are against it, but in the next release.
>> 
>> пт, 18 июн. 2021 г. в 13:08, Ivan Daschinsky <ivanda...@gmail.com>:
>> 
>>>>> we explicitly set use_ssl=True.
>>> Sorry, typo -- implicitly
>>> 
>>> пт, 18 июн. 2021 г. в 12:59, Ivan Daschinsky <ivanda...@gmail.com>:
>>> 
>>>> AHA! I see, this is not a bug -- this is a feature. If you pass username
>>>> and password, we explicitly set use_ssl=True. So if your cluster is
>>>> configured without ssl but with authentication,
>>>> you should explicitly pass use_ssl=False.
>>>> 
>>>> This behaviour is from old version and I suppose it is correct. Who
>> wants
>>>> authentication that sent without encryption?
>>>> 
>>>> пт, 18 июн. 2021 г. в 12:54, Ivan Daschinsky <ivanda...@gmail.com>:
>>>> 
>>>>> Just rechecked test on release branch, add extra check with cluster
>>>>> activation and putting some data -- everything works ok. Authentication
>>>>> enabled, persistence enabled,
>>>>> with and without ssl. Could you please provide you ignite config and
>>>>> your code.
>>>>> 
>>>>> пт, 18 июн. 2021 г. в 12:46, Ivan Daschinsky <ivanda...@gmail.com>:
>>>>> 
>>>>>> There is a test for it.
>>>>>> 
>>>>>> пт, 18 июн. 2021 г. в 12:30, Stephen Darlington <
>>>>>> stephen.darling...@gridgain.com>:
>>>>>> 
>>>>>>> Oh… can someone else check this: it appears that authenticated
>>>>>>> connections fail.
>>>>>>> 
>>>>>>> With Ignite 2.10 the connection times-out:
>>>>>>> 
>>>>>>> 
>> [10:28:58,015][WARNING][grid-timeout-worker-#22][ClientListenerNioListener]
>>>>>>> Unable to perform handshake within timeout [timeout=10000,
>> remoteAddr=/
>>>>>>> 127.0.0.1:54044]
>>>>>>> 
>>>>>>> Didn’t try this with 0.4.0 so not sure if it’s a regression, but it’s
>>>>>>> not great.
>>>>>>> 
>>>>>>>> On 18 Jun 2021, at 09:36, Stephen Darlington <
>>>>>>> stephen.darling...@gridgain.com> wrote:
>>>>>>>> 
>>>>>>>> +1
>>>>>>>> 
>>>>>>>> Checked on macOS, played with the new expiry APIs and a bunch of
>>>>>>> thefundamentals.
>>>>>>>> 
>>>>>>>>> On 17 Jun 2021, at 12:46, Pavel Tupitsyn <ptupit...@apache.org>
>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>> +1
>>>>>>>>> 
>>>>>>>>> Checked pip install from tar.gz on Python 3.8 on Ubuntu 20.04, ran
>>>>>>> some of
>>>>>>>>> the examples.
>>>>>>>>> 
>>>>>>>>> On Thu, Jun 17, 2021 at 2:32 PM Igor Sapego <isap...@apache.org>
>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>>> +1 from me
>>>>>>>>>> 
>>>>>>>>>> Best Regards,
>>>>>>>>>> Igor
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> On Thu, Jun 17, 2021 at 12:10 PM Ivan Daschinsky <
>>>>>>> ivanda...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>>> +1 From me
>>>>>>>>>>> Checked on Ubuntu 20.04 and windows 10
>>>>>>>>>>> 1. Installation from wheels for pythons 3.6 3.7 3.8 3.9
>>>>>>>>>>> 2. Native module work
>>>>>>>>>>> 3. Examples
>>>>>>>>>>> 
>>>>>>>>>>> Checked on Ubuntu 20.04 building from source package and correct
>>>>>>> work of
>>>>>>>>>>> result package.
>>>>>>>>>>> 
>>>>>>>>>>> Checked all sha256 checksums and gpg signatures.
>>>>>>>>>>> 
>>>>>>>>>>> Let's extend voting period till June 18, 15:00 UTC
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> ср, 16 июн. 2021 г. в 17:34, Ivan Daschinsky <
>>>>>>> ivanda...@apache.org>:
>>>>>>>>>>> 
>>>>>>>>>>>> The vote will end at June, 17 15:00 UTC.
>>>>>>>>>>>> 
>>>>>>>>>>>> ср, 16 июн. 2021 г. в 17:33, Ivan Daschinsky <
>>>>>>> ivanda...@apache.org>:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Dear Igniters!
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Release candidate binaries for subj are uploaded and ready for
>>>>>>> vote
>>>>>>>>>>>>> You can find them here:
>>>>>>>>>>>>> 
>>>>>>> https://dist.apache.org/repos/dist/dev/ignite/pyignite/0.5.0-rc1
>>>>>>>>>>>>> 
>>>>>>>>>>>>> If you follow the link above, you will find source package
>>>>>>> (*.tar.gz
>>>>>>>>>>> and
>>>>>>>>>>>> *.zip)
>>>>>>>>>>>>> and binary packages (wheels) for windows (amd64) and linux
>>>>>>> (x86_64)
>>>>>>>>>>>>> for pythons 36, 37, 38, 39. Also, there are sha512 and gpg
>>>>>>>>>> signatures.
>>>>>>>>>>>>> Code signing keys can be found here --
>>>>>>>>>>>> https://downloads.apache.org/ignite/KEYS
>>>>>>>>>>>>> Here you can find instructions how to verify packages
>>>>>>>>>>>>> https://www.apache.org/info/verification.html
>>>>>>>>>>>>> 
>>>>>>>>>>>>> You can install binary package for specific version of python
>>>>>>> using
>>>>>>>>>> pip
>>>>>>>>>>>>> For example do this on linux for python 3.8
>>>>>>>>>>>>>>> pip install pyignite-0.5.0-cp38-cp38-manylinux1_x86_64.whl
>>>>>>>>>>>>> 
>>>>>>>>>>>>> You can build and install package from source using this
>>>>>>> command:
>>>>>>>>>>>>>>> pip install pyignite-0.5.0.tar.gz
>>>>>>>>>>>>> You can build wheel on your platform using this command:
>>>>>>>>>>>>>>> pip wheel --no-deps pyignite-0.5.0.tar.gz
>>>>>>>>>>>>> 
>>>>>>>>>>>>> For building C module, you should have python headers and C
>>>>>>> compiler
>>>>>>>>>>>> installed.
>>>>>>>>>>>>> (i.e. for ubuntu sudo apt install build-essential python3-dev)
>>>>>>>>>>>>> In Mac OS X xcode-tools and python from homebrew are the best
>>>>>>> option.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> In order to check whether C module works, use following:
>>>>>>>>>>>>>>> from pyignite import _cutils
>>>>>>>>>>>>>>> print(_cutils.hashcode('test'))
>>>>>>>>>>>>>>> 3556498
>>>>>>>>>>>>> 
>>>>>>>>>>>>> You can find documentation here:
>>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>> 
>> https://apache-ignite-binary-protocol-client.readthedocs.io/en/0.5.0.rc1
>>>>>>>>>>>>> 
>>>>>>>>>>>>> You can find examples here (to check them, you should start
>>>>>>> ignite
>>>>>>>>>>>> locally):
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>> 
>> https://apache-ignite-binary-protocol-client.readthedocs.io/en/0.5.0.rc1/examples.html
>>>>>>>>>>>>> Also, examples can be found in source archive in examples
>>>>>>> subfolder.
>>>>>>>>>>>>> docker-compose.yml is supplied in order to start ignite
>>>>>>> quickly. (Use
>>>>>>>>>>>>> `docker-compose up -d` to start 3 nodes cluster and
>>>>>>> `docker-compose
>>>>>>>>>>>>> down` to shut down it)
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Release notes:
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>> 
>> https://gitbox.apache.org/repos/asf?p=ignite-python-thin-client.git;a=blob;f=RELEASE_NOTES.txt;h=9d2ae81af2de22ce9e8c9d3b7ece14dd9e75ca0e;hb=61c83cb0ab6752f019518b4a2cb0724bd027755f
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Git release tag was created:
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>> 
>> https://gitbox.apache.org/repos/asf?p=ignite-python-thin-client.git;a=tag;h=refs/tags/0.5.0.rc1
>>>>>>>>>>>>> 
>>>>>>>>>>>>> The vote is formal, see voting guidelines
>>>>>>>>>>>>> https://www.apache.org/foundation/voting.html
>>>>>>>>>>>>> 
>>>>>>>>>>>>> +1 - to accept pyignite-0.5.0-rc1
>>>>>>>>>>>>> 0 - don't care either way
>>>>>>>>>>>>> -1 - DO NOT accept pyignite-0.5.0-rc1
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> --
>>>>>>>>>>> Sincerely yours, Ivan Daschinskiy
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Sincerely yours, Ivan Daschinskiy
>>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Sincerely yours, Ivan Daschinskiy
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> Sincerely yours, Ivan Daschinskiy
>>>> 
>>> 
>>> 
>>> --
>>> Sincerely yours, Ivan Daschinskiy
>>> 
>> 
>> 
>> --
>> Sincerely yours, Ivan Daschinskiy
>> 


Reply via email to