Hello! -1 (binding)
The root element of the source zip file should be ignite-spring-data-all-ext-1.0.0-src/ directory. No other directories/files should be at the root of the source zip file. This is a *blocker* but should be very straightforward to fix. Regards, -- Ilya Kasnacheev пт, 25 июн. 2021 г. в 17:46, Sergei Ryzhov <s.vi.ryz...@gmail.com>: > +1 > Building modules from source and running tests successfully on Java 8 > > пт, 25 июн. 2021 г. в 16:52, Alex Plehanov <plehanov.a...@gmail.com>: > > > +1 > > > > Check sha512, sign of archives and versions of released artifacts (BTW, > > version of parent artifact is 1.0.0-SNAPSHOT, I don't think it's a > blocker > > now, but it's better to be fixed in the next releases). > > Check licenses with "mvn validate -DskipTests -P check-licenses" > > Build modules from the source (Note: build successfully on Java 8, but > > build on Java 11 has failed due to maven-javadoc-plugin. To build on Java > > 11 I have used this command: "mvn clean install -DskipTests > > -Dmaven.javadoc.skip=true") > > Run examples (create new maven project and copy sources from examples > > directories): > > from modules/spring-data-2.0-ext/examples with artifacts: Ignite > > v2.10.0/ignite-spring-data-2.0-ext v1.0.0/spring-data v2.0 > > from modules/spring-data-2.2-ext/examples with artifacts: Ignite > > v2.10.0/ignite-spring-data-2.2-ext v1.0.0/spring-data v2.2 > > > > пт, 25 июн. 2021 г. в 16:26, Ilya Kasnacheev <ilya.kasnach...@gmail.com > >: > > > > > Hello! > > > > > > The contents of the source package are much more reasonable now. > However, > > > there's still an issue that root element of zip archive is not a > > directory: > > > ~/Downloads/spring% unzip ignite-spring-data-all-ext-1.0.0-src.zip > > > Archive: ignite-spring-data-all-ext-1.0.0-src.zip > > > creating: checkstyle/ > > > inflating: checkstyle/checkstyle-suppressions.xml > > > inflating: checkstyle/checkstyle.xml > > > creating: config/ > > > inflating: config/example-ignite.xml > > > creating: modules/ > > > creating: modules/spring-data-2.0-ext/ > > > inflating: modules/spring-data-2.0-ext/README.txt > > > > > > > > > whereas > > > ~/Downloads% unzip -l apache-ignite-2.8.1-src.zip| head > > > Archive: apache-ignite-2.8.1-src.zip > > > 864220966caa4157c4fee8a1bc85171623963604 > > > Length Date Time Name > > > --------- ---------- ----- ---- > > > 0 2020-05-21 16:42 apache-ignite-2.8.1-src/ > > > 2029 2020-05-21 16:42 apache-ignite-2.8.1-src/.gitignore > > > 0 2020-05-21 16:42 apache-ignite-2.8.1-src/.idea/ > > > 0 2020-05-21 16:42 > > > apache-ignite-2.8.1-src/.idea/inspectionProfiles/ > > > 80905 2020-05-21 16:42 > > > apache-ignite-2.8.1-src/.idea/inspectionProfiles/Project_Default.xml > > > 5119 2020-05-21 16:42 apache-ignite-2.8.1-src/CONTRIBUTING.md > > > > > > > > > The root element of source sip should > > > be ignite-spring-data-all-ext-1.0.0-src/ directory. > > > > > > This is a small issue but a *blocker*, maybe you can do a quick > rebuild? > > > > > > Another issue is that I don't understand how to run examples. If I add > > the > > > entire directory as maven project, the examples/main directory is not > > > considered source root and will not be built/run > > > Maybe I'm missing something. > > > > > > Can you add is as an additional sources root, perhaps? You can even > > build a > > > jar with classifier 'examples' if that's OK. > > > > > > Regards, > > > > > > -- > > > Ilya Kasnacheev > > > > > > > > > пт, 25 июн. 2021 г. в 14:17, Mikhail Petrov <pmgheap....@gmail.com>: > > > > > > > +1 > > > > > > > > Checked on Ubuntu 20.04. Created separate Spring Applications for > each > > > > version of Spring Data Integrations using the Maven RC repository and > > > > following the documentation. Tested common use cases. > > > > > > > > On 25.06.2021 12:43, Nikita Amelchev wrote: > > > > > Dear Ignite Community, > > > > > > > > > > I have uploaded a release candidate of the following extension > > modules: > > > > > > > > > > spring-data-commons > > > > > spring-data-ext > > > > > spring-data-2.0-ext > > > > > spring-data-2.2-ext > > > > > > > > > > The release candidate of the extensions: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-all-ext/1.0.0-rc4/ > > > > > > > > > > The instruction for building from the source package is placed in > the > > > > > DEVNOTES file. > > > > > > > > > > The following staging can be used for testing: > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheignite-1520 > > > > > > > > > > Tags were created: > > > > > > > > > > ignite-spring-data-commons-1.0.0-rc4 > > > > > ignite-spring-data-ext-1.0.0-rc4 > > > > > ignite-spring-data-2.2-ext-1.0.0-rc4 > > > > > ignite-spring-data-2.0-ext-1.0.0-rc4 > > > > > ignite-spring-data-all-ext-1.0.0-rc4 > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=56db147fc059f3a64e0c00fe9d0a9d0d70ec97b0 > > > > > > > > > > RELEASE NOTES: > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb > > > > > > > > > > DOCUMENTATION: > > > > > Documentation of listed extensions was updated in the following > > issues: > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14662%2CIGNITE-14398%2CIGNITE-14493) > > > > > > > > > > The vote is formal, see voting guidelines > > > > > https://www.apache.org/foundation/voting.html > > > > > > > > > > +1 - to accept all the Apache Ignite spring-data-all-ext extensions > > > > > 1.0.0-rc4 listed in the thread > > > > > 0 - don't care either way > > > > > -1 - DO NOT accept either of the Apache Ignite spring-data-all-ext > > > > > extensions 1.0.0-rc4 (explain why) > > > > > > > > > > The vote will hold for 5 days and will end on May 30 2021 10:00 UTC > > > > > > > > > > > > > > > https://www.timeanddate.com/countdown/generic?iso=20210630T10&p0=0&font=cursive > > > > > > > > > > > > > > > > > -- > Best regards, > Sergei Ryzhov >
