AFAIK, this allows users to pass in custom VM options which may be undesirable.
On Thu, Jul 1, 2021 at 12:07 PM Zhenya Stanilovsky <arzamas...@mail.ru.invalid> wrote: > > > +1 for reverting, can anybody (possibly ticket starter?) explain how jvm > settings will rise some security problems ? > > > > >I suppose, that we should revert this particular line. I don't understand > >who ever considers vm options as sensitive info. > > > >ср, 30 июн. 2021 г., 22:52 Shishkov Ilya < shishkovi...@gmail.com >: > > > >> Hi Igniters, > >> > >> This feature [1, 2] prevents logging of the VM arguments when > >> IGNITE_TO_STRING_INCLUDE_SENSITIVE option is set to false. Till now, method > >> IgniteKernal#ackVmArguments remains mostly the same [3]. > >> > >> Is this behaviour actual now? Often, we should be able to get from logs the > >> actual VM options used at startup even if output of sensitive data is > >> restricted. > >> > >> 1. https://issues.apache.org/jira/browse/IGNITE-4991 > >> 2. > >> > >> > >> https://github.com/apache/ignite/pull/2428/commits/4f90b6fd77bd23fa818620f0757b792ba388ef93 > >> 3. > >> > >> > >> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java#L3002 > >> > > > > -- Regards, Atri Apache Concerted
