Hi, I want to add to 2.12 a fix [1] of a bug [2]. It affects users of metrics in case there are too many partitions (> 20000), we observed extensive heap usage.
[1] https://github.com/apache/ignite/pull/9518/files [2] https://issues.apache.org/jira/browse/IGNITE-15781 On Thu, Nov 18, 2021 at 12:59 PM Maksim Timonin <timonin.ma...@gmail.com> wrote: > Hi, guys, we have a blocker [1]. NPE for some SQL queries. I will fix it > in 1-2 days. > > https://issues.apache.org/jira/browse/IGNITE-15943 > > On Mon, Nov 15, 2021 at 2:57 PM Maxim Muzafarov <mmu...@apache.org> wrote: > >> Folks, >> >> I've fixed almost all the review comments [1]. Hopefully, the changes >> will be merged by the end of the week. >> >> [1] https://issues.apache.org/jira/browse/IGNITE-14744 >> >> On Mon, 8 Nov 2021 at 15:42, Nikita Amelchev <namelc...@apache.org> >> wrote: >> > >> > Hello, Pavel. >> > >> > The code freeze is blocked by two issues discussed above [1] [2]. The >> > issues are in the final review state and should be merged soon. >> > >> > The bugfix is useful and can be cherry-picked, thank you. >> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-15530 >> > [2] https://issues.apache.org/jira/browse/IGNITE-14744 >> > >> > >> > пн, 8 нояб. 2021 г. в 14:46, Pavel Tupitsyn <ptupit...@apache.org>: >> > >> > > >> > > Igniters, >> > > >> > > What's the code freeze status? >> > > Can I cherry-pick a bugfix [1] ? >> > > >> > > [1] https://issues.apache.org/jira/browse/IGNITE-15807 >> > > >> > > On Tue, Nov 2, 2021 at 4:39 PM Ivan Daschinsky <ivanda...@gmail.com> >> wrote: >> > > >> > > > Thanks, cherry-picked to master. >> > > > >> > > > вт, 2 нояб. 2021 г. в 16:00, Nikita Amelchev <namelc...@apache.org >> >: >> > > > >> > > > > Ivan, >> > > > > >> > > > > Yes, the patch can be cherry-picked. >> > > > > >> > > > > вт, 2 нояб. 2021 г. в 15:55, Ivan Daschinsky <ivanda...@gmail.com >> >: >> > > > > > >> > > > > > Since code freeze is postponed, may be I can cherry-pick my >> patch >> > > > already >> > > > > > merged to master? >> > > > > > https://issues.apache.org/jira/browse/IGNITE-15806 >> > > > > > >> > > > > > пт, 29 окт. 2021 г. в 20:24, Nikita Amelchev < >> namelc...@apache.org>: >> > > > > > >> > > > > > > Maksim T., Maxim M., Ok. >> > > > > > > >> > > > > > > I think we can move code freeze to +1 week to await these >> issues. >> > > > > > > >> > > > > > > пт, 29 окт. 2021 г. в 15:53, Maxim Muzafarov < >> mmu...@apache.org>: >> > > > > > > > >> > > > > > > > Folks, >> > > > > > > > >> > > > > > > > I've previously mentioned that I'd like to include the [1] >> issue in >> > > > > > > > the release. Currently, the status is "Patch Available" and >> it's >> > > > > > > > actively reviewing now. I'd be happy if we wait a couple of >> days >> > > > and >> > > > > > > > add this improvement to the release. >> > > > > > > > >> > > > > > > > I've also created an issue [2] to remove the ambiguity >> output >> > > > message >> > > > > > > > for the snapshot check and idle verify procedures. This is >> a minor >> > > > > > > > output message change, however, it was directly requested >> by users. >> > > > > > > > Would you don't mind if we include this issue in the >> release also? >> > > > > > > > >> > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14744 >> > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15849 >> > > > > > > > >> > > > > > > > On Fri, 29 Oct 2021 at 14:19, Maksim Timonin < >> > > > > timonin.ma...@gmail.com> >> > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > Status update on my issue: >> > > > > > > > > >> > > > > > > > > IGNITE-15530 [1] is in "Patch Available" state, Anton >> Vinogradov >> > > > > > > agreed to >> > > > > > > > > review this ticket. >> > > > > > > > > >> > > > > > > > > Also, I'm preparing IndexQuery docs in ticket >> IGNITE-15745 [2]. >> > > > I'm >> > > > > > > going >> > > > > > > > > to submit a patch with docs today/tomorrow, and want to >> include >> > > > > them in >> > > > > > > > > 2.12 too. >> > > > > > > > > >> > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 >> > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15745 >> > > > > > > > > >> > > > > > > > > On Thu, Oct 28, 2021 at 11:06 AM Ilya Kasnacheev < >> > > > > > > ilya.kasnach...@gmail.com> >> > > > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > > Hello! >> > > > > > > > > > >> > > > > > > > > > I have prepared a fix for sqlline.sh -e: >> > > > > > > > > > https://github.com/apache/ignite/pull/9536 >> > > > > > > > > > >> > > > > > > > > > If smbd reviews it, we can put it on 2.12. >> > > > > > > > > > >> > > > > > > > > > Regards, >> > > > > > > > > > -- >> > > > > > > > > > Ilya Kasnacheev >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > чт, 28 окт. 2021 г. в 10:39, Nikita Amelchev < >> > > > > namelc...@apache.org>: >> > > > > > > > > > >> > > > > > > > > > > Maksim, ok. >> > > > > > > > > > > >> > > > > > > > > > > Ivan, >> > > > > > > > > > > The minor issues can be considered if they will be >> merged >> > > > > before >> > > > > > > the >> > > > > > > > > > > code freeze. >> > > > > > > > > > > >> > > > > > > > > > > ср, 27 окт. 2021 г. в 14:55, Pavel Tupitsyn < >> > > > > ptupit...@apache.org >> > > > > > > >: >> > > > > > > > > > > > >> > > > > > > > > > > > Ivan, every additional ticket potentially moves the >> release >> > > > > date >> > > > > > > > > > further. >> > > > > > > > > > > > Also, AFAIK, Igor is on vacation and can't do a >> review this >> > > > > week. >> > > > > > > > > > > > >> > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:32 PM Ivan Daschinsky < >> > > > > > > ivanda...@gmail.com> >> > > > > > > > > > > wrote: >> > > > > > > > > > > > >> > > > > > > > > > > > > Pavel, but what is the problem to include a minor >> > > > > refactoring? >> > > > > > > > > > > Especially >> > > > > > > > > > > > > before code freeze? >> > > > > > > > > > > > > >> > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:25, Pavel Tupitsyn < >> > > > > > > ptupit...@apache.org>: >> > > > > > > > > > > > > >> > > > > > > > > > > > > > Ivan, IGNITE-15806 seems to be a minor >> refactoring, not >> > > > > sure >> > > > > > > we >> > > > > > > > > > > should >> > > > > > > > > > > > > > inflate the scope with this. >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:13 PM Ivan Daschinsky >> < >> > > > > > > > > > ivanda...@gmail.com >> > > > > > > > > > > > >> > > > > > > > > > > > > > wrote: >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > > Nikita, can we add >> > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-15806 >> > > > > > > > > > > > > > this >> > > > > > > > > > > > > > > ticket for release? >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 13:40, Maksim Timonin < >> > > > > > > > > > > timonin.ma...@gmail.com>: >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > Hi, >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > I'd like to include the ticket in 2.12. >> There was a >> > > > > > > performance >> > > > > > > > > > > > > issue, >> > > > > > > > > > > > > > I >> > > > > > > > > > > > > > > > spent some time trying to figure it out. I >> prepared >> > > > > some >> > > > > > > fixes >> > > > > > > > > > > and I >> > > > > > > > > > > > > am >> > > > > > > > > > > > > > > > going to submit a patch this week. >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > I think this issue is critical to include >> to 2.12 >> > > > > > > together with >> > > > > > > > > > > basic >> > > > > > > > > > > > > > > > IndexQuery functionality, because this >> ticket >> > > > > provides >> > > > > > > expected >> > > > > > > > > > > > > > behavior >> > > > > > > > > > > > > > > of >> > > > > > > > > > > > > > > > querying indexes - sorted over all nodes >> results. >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > - IGNITE-15530: IndexQuery has to use >> MergeSort >> > > > > reducer >> > > > > > > [1] >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > [1] >> > > > > https://issues.apache.org/jira/browse/IGNITE-15530 >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 1:23 PM Nikita >> Amelchev < >> > > > > > > > > > > > > namelc...@apache.org> >> > > > > > > > > > > > > > > > wrote: >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Hello. >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Code freeze is planned for Friday, >> October 29. >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > There are 40 unresolved issues [1] in the >> release >> > > > > > > scope. I >> > > > > > > > > > > suggest >> > > > > > > > > > > > > > > > > bumping up the fix version if they will >> not be >> > > > > > > resolved till >> > > > > > > > > > > the >> > > > > > > > > > > > > code >> > > > > > > > > > > > > > > > > freeze. >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Please, feel free to write if some of >> them are >> > > > > > > critical to be >> > > > > > > > > > > in >> > > > > > > > > > > > > the >> > > > > > > > > > > > > > > > 2.12. >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Also, please, pay attention to unresolved >> > > > > documentation >> > > > > > > > > > > issues. [2] >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > Sergey, Petr, thanks for helping with TC. >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > [1] >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > >> > > > > >> > > > >> https://issues.apache.org/jira/issues/?jql=(project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.12%27))%20AND%20(component%20is%20EMPTY%20OR%20component%20not%20in%20(documentation))%20%20and%20status%20not%20in%20(%27CLOSED%27%2C%20%27RESOLVED%27)%20ORDER%20BY%20priority%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20 >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > [2] >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > >> > > > > >> > > > >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20%27Ignite%27%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20(%272.12%27)%20AND%20status%20NOT%20IN%20(Resolved%2C%20Closed)%20AND%20component%20in%20(documentation)%20ORDER%20BY%20priority%20%20%20%20%20%20%20%20%20 >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > вт, 26 окт. 2021 г. в 12:50, Petr Ivanov < >> > > > > > > > > > mr.wei...@gmail.com >> > > > > > > > > > > >: >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > Thanks, Sergey. >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > I've also reconfigured nightly builds >> for >> > > > > ignite-2.12 >> > > > > > > > > > branch. >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > On 22 Oct 2021, at 17:32, Сергей >> Утцель < >> > > > > > > > > > utt...@gmail.com> >> > > > > > > > > > > > > > wrote: >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > I configured TC bot to 'ignite-2.12' >> instead >> > > > of >> > > > > > > > > > > 'ignite-2.11' >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > -- >> > > > > > > > > > > > > > > > > Best wishes, >> > > > > > > > > > > > > > > > > Amelchev Nikita >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > -- >> > > > > > > > > > > > > > > Sincerely yours, Ivan Daschinskiy >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > -- >> > > > > > > > > > > > > Sincerely yours, Ivan Daschinskiy >> > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > -- >> > > > > > > > > > > Best wishes, >> > > > > > > > > > > Amelchev Nikita >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > Best wishes, >> > > > > > > Amelchev Nikita >> > > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > Sincerely yours, Ivan Daschinskiy >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Best wishes, >> > > > > Amelchev Nikita >> > > > > >> > > > >> > > > >> > > > -- >> > > > Sincerely yours, Ivan Daschinskiy >> > > > >> > >> > >> > >> > -- >> > Best wishes, >> > Amelchev Nikita >> >
