Maksim, thank you for the suggestion. I've never used NullAway, but after having a quick look I think it might be an overkill, since it is a plugin for the ErrorProne, which is a separate tool. I recall some efforts of introducing ErrorProne to Ignite 3 and they were not successful. But again, I don't have much experience in that regard. I wonder if IDEA inspections would be enough, since they are easy to use during development and AFAIK are already run during the TC builds.
Regarding Ignite 2, I don't know if it would be viable to add these annotations to the existing code (in order to have meaningful checks), since the codebase is so large. But nevertheless we can try to adopt the same approach there as well. On Fri, Dec 17, 2021 at 12:10 PM Maksim Timonin <timoninma...@apache.org> wrote: > Hi! > > There is a pretty popular project NullAway [1] that checks code of a > project in compile-time for possible NPE. AFAIK, it works only with the > "@Nullable" annotation. I think we can try to add this check to Ignite2 and > 3. > > But I wonder, whether smbd already tried to introduce this check? If not, I > can try, WDYT? > > [1] https://github.com/uber/NullAway > > On Fri, Dec 17, 2021 at 9:04 AM ткаленко кирилл <tkalkir...@yandex.ru> > wrote: > > > I'm for the second option. > > > -- With regards, Aleksandr Polovtcev
