I am +1 for removing ZookeeperIpFinder from ignite-zookeeper module. It is not needed here.
ср, 22 дек. 2021 г. в 14:00, Ivan Daschinsky <ivanda...@gmail.com>: > >> a lot of code in core code base is dedicated for enabling it. > It is simply not true. ZookeeperDiscovery has nothing common with > ZookeeperIpFinder. > > The last one is simply one class and similar to others IP finders. > > ср, 22 дек. 2021 г. в 13:25, Ilya Kasnacheev <ilya.kasnach...@gmail.com>: > >> Hello! >> >> I think it might not be a good idea, since Zookeeper IP Finder is not >> stand-alone - a lot of code in core code base is dedicated for enabling >> it. >> This code may break unnoticed if Zookeeper IP Finder is not built/tested >> on >> every commit. >> >> Regards, >> -- >> Ilya Kasnacheev >> >> >> ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s.vi.ryz...@gmail.com>: >> >> > Hi, igniters, >> > >> > I've created an issue [1] to move the zookeeper IP-finder to the >> > ignite-extensions. The motivation is the same as with migration of >> > cloud-based IP-finders - to remove integration dependency of the >> > release cycle on Ignite releases. Also, the log4j dependency with >> > vulnerabilities (needed for Apache Curator) will be removed from the >> Ignite >> > release. >> > >> > Any objections? >> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-16182 >> > -- >> > Best regards, >> > Sergei Ryzhov >> > >> > > > -- > Sincerely yours, Ivan Daschinskiy > -- Sincerely yours, Ivan Daschinskiy
