Looks great! On Wed, Sep 7, 2022 at 2:57 PM Nikita Amelchev <namelc...@apache.org> wrote:
> Pavel, Looks cool. > > +1 to add to the default log config. > > вт, 6 сент. 2022 г. в 13:20, Pavel Tupitsyn <ptupit...@apache.org>: > > > > Thanks for the explanation. > > > > Yes, I think we can apply the same color scheme everywhere, but let's > hear > > more opinions. > > > > On Tue, Sep 6, 2022 at 1:10 PM Pavel Pereslegin <xxt...@gmail.com> > wrote: > > > > > Hello Pavel, > > > > > > I decided that it's safer to apply this only to our tests first, and > > > then if everything is ok, apply the same logger pattern to the default > > > production log4j-config, > > > If you think it's worth applying them now to the production config - I > > > can do it. > > > > > > вт, 6 сент. 2022 г. в 12:33, Pavel Tupitsyn <ptupit...@apache.org>: > > > > > > > > Looks great! > > > > > > > > However, I'm a bit confused - does it apply to node output in > production > > > > build? > > > > Why does it say "test console output"? > > > > > > > > On Tue, Sep 6, 2022 at 12:20 PM Mirza Aliev <alievmi...@gmail.com> > > > wrote: > > > > > > > > > Hello Pavel! Looks awesome! Thank you for the enhancement! > > > > > > > > > > вт, 6 сент. 2022 г. в 10:37, Pavel Pereslegin <xxt...@gmail.com>: > > > > > > > > > > > Hello Igniters! > > > > > > > > > > > > Recently completed Ignite migration to use log4j2 [1]. > > > > > > Log4j2 supports ANSI colorization in the console [2], which can > help > > > > > > in parsing log output. > > > > > > As an experiment, I would like to colorize the test console > output > > > [3]. > > > > > > > > > > > > The color palette is similar to spring boot, see light [4] and > dark > > > > > > [5] console output example. > > > > > > > > > > > > If there are no objections, I will merge these changes soon [6]. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-16650 > > > > > > [2] > > > https://logging.apache.org/log4j/2.x/manual/layouts.html#Patterns > > > > > > [3] https://issues.apache.org/jira/browse/IGNITE-17442 > > > > > > [4] > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/attachment/13048986/light-console.jpg > > > > > > [5] > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/attachment/13048991/dark-console-example.png > > > > > > [6] https://github.com/apache/ignite/pull/10229/files > > > > > > > > > > > > > > > > > > -- > Best wishes, > Amelchev Nikita >
