Approved with a suggestion On Thu, Jul 6, 2023 at 4:27 PM Maksim Timonin <timoninma...@apache.org> wrote:
> Hi Pavel, > > Could you please make a review? > > https://github.com/apache/ignite-website/pull/169/files > > Thanks! > > Maksim > > On Thu, Jul 6, 2023 at 12:48 PM Pavel Tupitsyn <ptupit...@apache.org> > wrote: > > > Hi Maksim, > > > > Yes, please go ahead with the release notes patch. > > My bad - I forgot to update them even though it was mentioned in the > > ticket. > > > > Note that ClientConfiguration#setAutoBinaryConfigurationEnabled provides > a > > way to revert to the old behavior. > > > > Thank you, > > Pavel > > > > On Thu, Jul 6, 2023 at 11:42 AM Maksim Timonin <timoninma...@apache.org> > > wrote: > > > > > Hi Igniters! > > > > > > Release 2.14 broke backward compatibility for java thin clients in the > > > ticket [1]. Before this release default value > > > ClientConfiguration#compactFooter was "false", but since the release > the > > > value fetched from a server node, and by default it returns "true". > This > > > change happened with no warning to a user. > > > > > > Before we agreed that even releases (2.12, 2.14, etc) could break > > > compatibility, but these breaking changes must be announced at least > one > > > release before. For example in this case, the new behavior would have > > been > > > disabled by default and would wrote a WARN in case of client/server > > > configurations difference, default value would have changed in the next > > > even release 2.16. > > > > > > Also, this change wasn't mentioned as breaking in the release notes > [2]. > > > > > > We can't revert this change now, as release 2.14 and 2.15 have already > > been > > > published. But what do you think to update the release notes at least > on > > > the web site? Should we update release notes for 2.15 also? > > > > > > I'd like to prepare a patch for the update for both releases. WDYT? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-16038 > > > [2] https://ignite.apache.org/releases/2.14.0/release_notes.html > > > > > >
