1. I will add README 2. Not sure about project module, but will try to do smth. 3. Will try to make demo running from Ignite project, this will require to adjust build scripts.
On Sun, Mar 22, 2015 at 4:17 PM, Dmitriy Setrakyan <[email protected]> wrote: > One more issue. > > 3. When running this from Ignite project, I get the following error: > --- > dsetmac:bin: ignite-45 $ schema-import.sh > Error: Could not find or load main class > org.apache.ignite.schema.ui.SchemaImportApp > --- > > I don't think it was ever executed from the project. > > I file a ticket: https://issues.apache.org/jira/browse/IGNITE-549 . Please > take a look at it whenever you get a chance. > > D. > > On Sun, Mar 22, 2015 at 1:56 AM, Dmitriy Setrakyan <[email protected]> > wrote: > > > Alexey K, > > > > I have reviewed the schema-import demo and it looks ver nice. > > > > I have several comments though. > > > > 1. README > > I understand that you documented it in readme.io, but I still think that > > we should explicitly say so in the README file and provide a link to the > > readme.io documentation. > > > > 2. The project module is not enabled automatically. Can you please add it > > to Ignite just like example module? > > > > Thanks, > > D. > > > -- Alexey Kuznetsov GridGain Systems www.gridgain.com
