Thanks for your comments. I am not sure if I understood your comments correctly.
For your concern about not reusing ClusterGroupAdapter#nodes, I mentioned that I cannot see a clear mechanism of reusing existing nodes() (without major refactoring of ClusterGroupAdapter#nodes which I try to avoid since ClusterGroupAdapter#nodes is a heavily used method). If there is a method I missed, please let me know. For the tests, test I added gets all the hostnames for test cluster using new method, gets localnode's hostnames and tests if all of localnode's hostnames are present in hostnames result returned by hostNames() method. I did not understand your concern around it (is it that test cluster might have single node)? Please elaborate a bit. Thanks! On Tue, Jun 23, 2015 at 4:54 PM, Artiom Shutak <[email protected]> wrote: > See my comments for test at jira. > > In future, can you please fix all comments before giving new patch for > review? > > -- Artem -- > > On Tue, Jun 23, 2015 at 12:50 PM, Atri Sharma <[email protected]> wrote: > > > Added tests. > > > > Please see and let me know your feedback and comments. > > > > On Mon, Jun 22, 2015 at 4:09 PM, Artiom Shutak <[email protected]> > > wrote: > > > > > Hi, see my comments at jira. > > > > > > -- Artem -- > > > > > > On Fri, Jun 19, 2015 at 6:43 PM, Atri Sharma <[email protected]> > > wrote: > > > > > > > Folks, > > > > > > > > I request to please have a look AT IGNITE 1006. It has been ready > for a > > > > while. > > > > > > > > Please let me know if anything is needed. > > > > > > > > > > > > > > > -- > > Regards, > > > > Atri > > *l'apprenant* > > > -- Regards, Atri *l'apprenant*
