Done. "CacheConfiguration#transactionManagerLookupClassName" has been deprecated. TransactionConfiguration#txManagerLookupClassName has been created instead.
If IgniteConfiguration.getTransactionConfiguration().getTxManagerLookupClassName() is specified it will be used for all caches on the node. If user try to create a cache with another CacheConfiguration#transactionManagerLookupClassName exception will be thrown. If IgniteConfiguration.getTransactionConfiguration().getTxManagerLookupClassName() is not specified no transaction manager will be used until user start a cache with CacheConfiguration#transactionManagerLookupClassName != null. On Fri, Jul 3, 2015 at 6:04 PM, Dmitriy Setrakyan <[email protected]> wrote: > On Fri, Jul 3, 2015 at 1:22 AM, Sergey Evdokimov <[email protected]> > wrote: > > > +1 > > I will move CacheConfiguration.transactionManagerLookupClassName property > > to IgniteConfiguration.transactionManagerLookupClassName. All caches will > > use same GridCacheTmLookup. > > > > Sergey, a couple of comments: > > 1. It should be moved to TransactionConfiguration, not IgniteConfiguration. > 2. Please make sure you do not delete the old method, but deprecate it. It > should continue to work exactly as it works now for backward compatibility. > > > > > > On Fri, Jul 3, 2015 at 1:41 AM, Yakov Zhdanov <[email protected]> > wrote: > > > > > +1 for the change. > > > > > > --Yakov > > > > > > 2015-07-02 14:48 GMT-07:00 Alexey Goncharuk < > [email protected] > > >: > > > > > > > Sorry, the message was sent earlier than I expected :) > > > > > > > > I think we should deprecate per-cache tmLookup and move it to ignite > > > > configuration. If per-cache configuration is used, we should not > allow > > > > cross-cache transactions. User should specify single tmLookup on > ignite > > > > configuration if he wants to use cross-cache transactions via JTA. > This > > > way > > > > we can have single JTA transaction manager. > > > > > > > > Thoughts? > > > > > > > > 2015-07-02 14:47 GMT-07:00 Alexey Goncharuk < > > [email protected] > > > >: > > > > > > > > > Folks, > > > > > > > > > > > > > > > > > > > >
