On Sun, Jul 26, 2015 at 10:39 PM, Branko Čibej <[email protected]> wrote:
> On 27.07.2015 07:04, Dmitriy Setrakyan wrote: > > Igniters, > > > > I believe several very valid points have been made on the general@ list > > about our Jira handling, and how we should improve our Jira process. > > > > I have tried to outline the Jira Process we should follow on our Wiki: > > https://cwiki.apache.org/confluence/display/IGNITE/Jira+Process > > > > Please review and provide comments. Let's try to finalize it within the > > next couple of days. > > This describes a commit-then-review process. This is absolutely not what > you want. There is no need to ask for patch review before committing; > this should happen after commit. The only case where the ticket review > stage makes sense is when someone who is not a committer is writing the > patch; or when the committer feels she needs extra eyes on the change. > Brane, I am not sure if I understood you correctly. The process that I would like to see in Ignite is that absolutely every ticket undergoes a review process before it gets merged to the main master branch, regardless of whether it is done by a committer or not. Are you suggesting that the review process for committers should be optional? > > -- Brane > **** >
