I like this idea. One thing to be careful of is to not modify the tests themselves when you move them. It's hard to see such changes in gerrit and it's hard to track them down in git history.
On Thu, Nov 16, 2017 at 5:34 AM, Jin Chul Kim <[email protected]> wrote: > Hi, > > https://issues.apache.org/jira/browse/IMPALA-5078 > > I'd like to get your advice if I will refactor expr-test.cc. Henry suggests > grouping tests by string instructions and move them to expr-string-test.cc. > I like his idea. You know filenames (e.g. cast-functions*, > timestamp-functions*, aggregate-functions*) of backend kernel code in exprs > have a same pattern, so I would suggest a pair of kernel code and unit > test. For example, > (cast-functions*, expr-cast-test.cc), > (timestamp-functions*, expr-timestamp-test.cc), > (aggregate-functions*, expr-aggregate-test.cc), > ... > > Do you have any suggestion or comment on this? Thanks. > > Best regards, > Jinchul
