This is a DCHECK_EQ, so it won't fire if you compile with -release. On Wed, Apr 25, 2018 at 6:49 AM, Quanlong Huang <huang_quanl...@126.com> wrote:
> -1 (non-binding) > > Not mean to block you, but when I played around on this version I hit a > crash (IMPALA-6927). > I'm going to upgrade our production Impala cluster with this version. But > I have concerns if users can crash the impalad when they just clicking on > the webpage... > > > Sorry for my late vote. > > > At 2018-04-21 06:58:01, "Jim Apple" <jbap...@cloudera.com> wrote: > >+1: I trust the results of the Jenkins job. > > > >On Fri, Apr 20, 2018 at 3:45 PM, Sailesh Mukil <sail...@cloudera.com> > wrote: > > > >> +1 (binding) > >> > >> - Validated the sha512 file > >> - Validated the GPG signature > >> - Ran the release test job: > >> https://jenkins.impala.io/view/Utility/job/release-test-ub1604/10/ > >> > >> Also, thanks Lars for bringing up IMPALA-4744. I'm not fixing it for > this > >> release, since a fix for that would require a new RC, which would > restart > >> the entire voting process. Since we know that it's not a regression and > >> only a minor cosmetic drawback. I've updated the release documentation > to > >> ensure that we have it fixed for every upcoming release henceforth. > >> > >> On Fri, Apr 20, 2018 at 1:55 PM, Thomas Tauber-Marshall < > >> tmarsh...@cloudera.com> wrote: > >> > >> > +1 (binding) > >> > > >> > Ran the release test job: > >> > https://jenkins.impala.io/job/release-test-ub1604/9/ > >> > > >> > > >> > On Fri, Apr 20, 2018 at 11:58 AM Lars Volker <l...@cloudera.com> wrote: > >> > > >> > > +1 (binding) > >> > > > >> > > * Validated that the sha512 file has been fixed > >> > > * Validated the GPG signature > >> > > * Ran the release test job on jenkins.impala.io, result is here > >> > > <https://jenkins.impala.io/view/Utility/job/release-test-ub1604/8/> > >> > > * Unpacked and compiled the tarball on my development machine, made > >> sure > >> > > the daemon starts, and ran some queries. > >> > > > >> > > I noticed that the build identifies itself as "impalad version > >> > > 2.12.0-RELEASE DEBUG (build Could not obtain git hash)". > >> > > This is tracked in IMPALA-4744 > >> > > <https://issues.apache.org/jira/browse/IMPALA-4744> and we're > released > >> > > with > >> > > this before. Should we require a subsequent RC, we can manually > change > >> > > GIT_HASH in bin/save-version.sh. > >> > > > >> > > Thanks for creating the RC, Sailesh! > >> > > > >> > > > >> > > On Thu, Apr 19, 2018 at 4:57 PM, Sailesh Mukil < > sail...@cloudera.com> > >> > > wrote: > >> > > > >> > > > I've already updated that file to not have an absolute path. Could > >> you > >> > > > download that and try again? > >> > > > > >> > > > On Thu, Apr 19, 2018, 4:15 PM Jim Apple <jbap...@cloudera.com> > >> wrote: > >> > > > > >> > > > > -1: > >> > > > > > >> > > > > /tmp/foo:$ sha512sum --check apache-impala-2.12.0.tar.gz.sha512 > >> > > > > sha512sum: /tmp/apache-impala-2.12.0.tar.gz: No such file or > >> > directory > >> > > > > /tmp/apache-impala-2.12.0.tar.gz: FAILED open or read > >> > > > > sha512sum: WARNING: 1 listed file could not be read > >> > > > > > >> > > > > > >> > > > > On Thu, Apr 19, 2018 at 2:40 PM, Sailesh Mukil < > >> sail...@cloudera.com > >> > > > >> > > > > wrote: > >> > > > > > >> > > > > > This is a vote to release Impala 2.12.0 > >> > > > > > > >> > > > > > The artifacts for testing can be downloaded from: > >> > > > > > https://dist.apache.org/repos/dist/dev/impala/2.12.0/RC1/ > >> > > > > > Git tag: 2.12.0-rc1 > >> > > > > > Tree hash: 07f18b8539a044c506bb3ff5a118f3b7b5ea1cf7 > >> > > > > > > >> > > > > > Please vote +1 or -1. -1 votes should be accompanied by an > >> > > explanation > >> > > > of > >> > > > > > the reason. Only PMC members have binding votes, but other > >> > > > > > community members are encouraged to cast non-binding votes. > This > >> > vote > >> > > > > will > >> > > > > > pass if there are 3 binding +1 votes and more binding +1 votes > >> than > >> > > -1 > >> > > > > > votes. > >> > > > > > > >> > > > > > This wiki page describes how to check the release before you > >> vote: > >> > > > > > https://cwiki.apache.org/confluence/display/IMPALA/How+ > >> to+Release# > >> > > > > > > >> > > > > > The vote will be open until 3:00PM PST on Tuesday, April 24 > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> >
