Seems fine, especially since we do the rebase as our submission strategy anyway, so we're already accepting/testing something that's likely to get rebased, and we may as well minimize that window.
I'd be in favor of the bot also carrying the votes. On Thu, Jun 7, 2018 at 1:24 PM, Tim Armstrong <[email protected]> wrote: > One annoyance with our precommit job is the requirement to manually rebase > the change before starting the merge. Failure to do so either leads to > false positives or false negatives - builds that failed because they were > missing a flaky/broken test fix and builds that succeeded despite > interacting badly with a previous fix. > > What do people think about modifying gerrit-verify-dryrun to automatically > rebase the patch (by the programmatic equivalent of hitting the "Rebase" > button) at the start of the job? The patch author would still have to carry > the +2 but this might make our lives a bit easier. > > - Tim >
