Update: I'm not able to repro this anymore. I just did a clean build and don't see the errors now. Strange.
On Thu, Jul 19, 2018 at 5:57 PM Tim Armstrong <[email protected]> wrote: > It's weird that it thinks that thrift_sasl-0.1.0.tar.gz is a version of > thrift. Yep. For some reason it was expecting a thrift dependency and started assuming thrift_sasl* to be a thrift library with version sasl_*. > Do you have a thrift tarball in infra/python/deps/? You could try > rerunning ./infra/python/deps/download_requirements > I have it now because I added a thrift dependency to get my build working. Otherwise, it was not present before (I'm pretty sure I checked it). Yea, I tried the download_requirements script multiple times before I reported here. > > On Thu, Jul 19, 2018 at 5:30 PM, Bharath Vissapragada < > [email protected]> wrote: > > > On Thu, Jul 19, 2018 at 5:20 PM Tianyi Wang <[email protected]> > > wrote: > > > > > - How could an impyla commit on github break impala given that we > didn't > > > change the dependent impyla version in > > > > > > https://github.com/apache/impala/blame/2a40e8f2a973391b61165ebd95cb30 > > b9b67d93ba/infra/python/deps/compiled-requirements.txt > > > ? > > > > > > > I'm wondering the same thing. So, I checked the sources from the > downloaded > > impyla-0.14.0.tar.gz and it does not contain the changes from the commit > I > > linked. It is possible that something funky is happening on my machine, > if > > no one else is hitting this. > > > > > > > - I think the diff makes sense. Though we don't use the pip-downloaded > > > thrift but we can pin it to make sure that other dependencies work with > > > thrift 0.9.3. > > > > > > On Thu, Jul 19, 2018 at 4:47 PM Bharath Vissapragada > > > <[email protected]> wrote: > > > > > > > Digging a bit more, looks like this impyla change > > > > < > > > > > > > > https://github.com/cloudera/impyla/commit/0b5967259d350c6e24d8a2a9ffdaec > > cb4d7eb7dc > > > > > > > > > broke from 2 days ago broke our dependency chain. For now I unblocked > > my > > > > build with the following diff, but I'm not totally sure that is the > > right > > > > approach, since we have a patched version of thrift in > > > > > > > $IMPALA_HOME/toolchain/thrift-0.9.0-p11/python/lib/python2. > > 7/site-packages > > > > > > > > pip experts, any thoughts? > > > > > > > > diff --git a/infra/python/deps/compiled-requirements.txt > > > > b/infra/python/deps/compiled-requirements.txt > > > > index 2c5590e..0adb5aa 100644 > > > > --- a/infra/python/deps/compiled-requirements.txt > > > > +++ b/infra/python/deps/compiled-requirements.txt > > > > @@ -28,6 +28,7 @@ impyla == 0.14.0 > > > > sasl == 0.1.3 > > > > six == 1.11.0 > > > > thrift-sasl == 0.1.0 > > > > + thrift == 0.9.3 > > > > psutil == 0.7.1 > > > > # Required for Kudu: > > > > Cython == 0.23.4 > > > > > > > > > > > > > > > > > > > > On Thu, Jul 19, 2018 at 4:26 PM Bharath Vissapragada < > > > > [email protected]> > > > > wrote: > > > > > > > > > I started hitting this suddenly (on Ubuntu-14.04). Anyone knows how > > to > > > > fix > > > > > this? > > > > > > > > > > INFO:bootstrap_virtualenv:Installing compiled requirements into the > > > > > virtualenv > > > > > Traceback (most recent call last): > > > > > File > > > > "/home/bharath/Impala/bin/../infra/python/bootstrap_virtualenv.py", > > > > > line 390, in <module> > > > > > if install_compiled_deps_if_possible(): > > > > > File > > > > "/home/bharath/Impala/bin/../infra/python/bootstrap_virtualenv.py", > > > > > line 239, in install_compiled_deps_if_possible > > > > > exec_pip_install(["-r", COMPILED_REQS_PATH], cc=cc, env=env) > > > > > File > > > > "/home/bharath/Impala/bin/../infra/python/bootstrap_virtualenv.py", > > > > > line 165, in exec_pip_install > > > > > exec_cmd(cmd, env=env) > > > > > File > > > > "/home/bharath/Impala/bin/../infra/python/bootstrap_virtualenv.py", > > > > > line 102, in exec_cmd > > > > > % (args, output)) > > > > > Exception: Command returned non-zero status > > > > > .......... > > > > > .......... <snip> > > > > > .......... > > > > > Collecting thrift (from impyla==0.14.0->-r > > > > > /home/bharath/Impala/bin/../infra/python/deps/compiled- > > requirements.txt > > > > > (line 6)) > > > > > 0 location(s) to search for versions of thrift: > > > > > Found link > > > > > file:///home/bharath/Impala/infra/python/deps/thrift_sasl- > > 0.1.0.tar.gz, > > > > > version: sasl-0.1.0 > > > > > Local files found: > > > > > /home/bharath/Impala/infra/python/deps/thrift_sasl-0.1.0.tar.gz > > > > > Could not find a version that satisfies the requirement thrift > > (from > > > > > impyla==0.14.0->-r > > > > > /home/bharath/Impala/bin/../infra/python/deps/compiled- > > requirements.txt > > > > > (line 6)) (from versions: sasl-0.1.0) > > > > > Cleaning up... > > > > > Removing source in /tmp/pip-build-Xn5A25/argparse > > > > > Removing source in /tmp/pip-build-Xn5A25/Fabric > > > > > Removing source in /tmp/pip-build-Xn5A25/paramiko > > > > > Removing source in /tmp/pip-build-Xn5A25/ecdsa > > > > > Removing source in /tmp/pip-build-Xn5A25/pycrypto > > > > > Removing source in /tmp/pip-build-Xn5A25/impyla > > > > > Removing source in /tmp/pip-build-Xn5A25/bitarray > > > > > Removing source in /tmp/pip-build-Xn5A25/sasl > > > > > Removing source in /tmp/pip-build-Xn5A25/thrift-sasl > > > > > Removing source in /tmp/pip-build-Xn5A25/psutil > > > > > Removing source in /tmp/pip-build-Xn5A25/Cython > > > > > Removing source in /tmp/pip-build-Xn5A25/numpy > > > > > Removing source in /tmp/pip-build-Xn5A25/pytz > > > > > No matching distribution found for thrift (from impyla==0.14.0->-r > > > > > /home/bharath/Impala/bin/../infra/python/deps/compiled- > > requirements.txt > > > > > (line 6)) > > > > > Exception information: > > > > > Traceback (most recent call last): > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/basecommand.py", > > > > > line 223, in main > > > > > status = self.run(options, args) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/commands/install.py", > > > > > line 282, in run > > > > > requirement_set.prepare_files(finder) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/req/req_set.py", > > > > > line 334, in prepare_files > > > > > functools.partial(self._prepare_file, finder)) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/req/req_set.py", > > > > > line 321, in _walk_req_to_install > > > > > more_reqs = handler(req_to_install) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/req/req_set.py", > > > > > line 461, in _prepare_file > > > > > req_to_install.populate_link(finder, self.upgrade) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/req/req_install.py", > > > > > line 249, in populate_link > > > > > self.link = finder.find_requirement(self, upgrade) > > > > > File > > > > > > > > > > > > "/home/bharath/Impala/infra/python/env/local/lib/python2. > > 7/site-packages/pip/index.py", > > > > > line 571, in find_requirement > > > > > 'No matching distribution found for %s' % req > > > > > DistributionNotFound: No matching distribution found for thrift > (from > > > > > impyla==0.14.0->-r > > > > > /home/bharath/Impala/bin/../infra/python/deps/compiled- > > requirements.txt > > > > > (line 6)) > > > > > > > > > > > > > > > > > -- > > > Tianyi Wang > > > > > >
