It seems like flake8 might need some adjustment of its policies. Here are
the most common issues in the current test code:
109 : E125 continuation line with same indent as next logical line
110 : E701 multiple statements on one line (colon)
129 : E231 missing whitespace after ','
185 : E251 unexpected spaces around keyword / parameter equals
187 : E121 continuation line under-indented for hanging indent
288 : E502 the backslash is redundant between brackets
368 : E302 expected 2 blank lines, found 1
1295 : E128 continuation line under-indented for visual indent
Maybe worth just disabling some of the indentation-related ones to start?
On Mon, Jul 30, 2018 at 4:09 PM, Tim Armstrong <
[email protected]> wrote:
> I have a few updates.
>
> I added an automatic build job for docs changes:
> https://jenkins.impala.io/job/gerrit-docs-auto-test/
>
> I'm going to disable the "Build started" message for
> gerrit-code-review-checks. It seems a bit too chatty. Let me know if you
> disagree.
>
> I'm adding a job that automatically does some checks on the diff and posts
> code review comments. I started off with Python flake8 comments.
>
> Let me know if you see any problems or if it turns out to be too noisy.
>
>
>
> On Mon, Jul 23, 2018 at 11:55 AM, Tim Armstrong <[email protected]>
> wrote:
>
> > Hi All,
> > I'm enabling an automatic precommit job for code reviews uploaded to
> > gerrit that will run RAT, clang-tidy and a GCC debug compilation. This is
> > to provide faster feedback on code reviews: https://issues.apache.org/
> > jira/browse/IMPALA-7317 . I'll add some more checks but I'm wanting to
> > test the basic mechanism for a bit now.
> >
> > It excludes docs/ commits.
> >
> > Let me know if you see any problems with it.
> >
> > Thanks,
> > Tim
> >
>
--
Todd Lipcon
Software Engineer, Cloudera
