Hi folks,

To address IMPALA-6543, there's a new test in parallel-all-tests that makes
sure that any Python scripts use Python2.6-compatible syntax. Note that
this will catch the "try/catch/finally" style of bug, but not the
"itertools.count(start=1)" kind of bug (python2.7 changed the signature of
itertools.count).

The relevant diff was:

$diff -u /tmp/b /tmp/a
--- /tmp/b 2018-09-27 12:29:15.000000000 -0700
+++ /tmp/a 2018-09-27 12:28:58.000000000 -0700
@@ -23,6 +23,14 @@
     if (restring != null && !restring.equals("SUCCESS")) {
         failed_job_urls.add(result.getAbsoluteUrl())
     }
+}, Python26Compatibility: {
+    result = build job: 'python26-incompatibility-check', propagate:
false, parameters:
+    [string(name: 'IMPALA_REPO_URL', value: IMPALA_REPO_URL),
+     string(name: 'IMPALA_REPO_BRANCH', value: IMPALA_REPO_BRANCH)]
+    restring = result.getResult()
+    if (restring != null && !restring.equals("SUCCESS")) {
+        failed_job_urls.add(result.getAbsoluteUrl())
+    }
 }, TidyAndBuildOnlyAndRat: {
     result = build job: 'clang-tidy-ub1604', propagate: false, parameters:
     [string(name: 'IMPALA_REPO_URL', value: IMPALA_REPO_URL),

This will show up in your GVO builds. I've tested it, but of course let me
know if you run into any trouble.

Thanks!

Reply via email to