+1, thanks for working on this! On Fri, Apr 5, 2019 at 11:18 AM Jim Apple <[email protected]> wrote:
> I'm in favor. Given the importance of remote reads, I would even be in > favor of these if it DID extend the critical path. > > On Fri, Apr 5, 2019 at 10:41 AM Tim Armstrong <[email protected]> > wrote: > > > This is really about testing the dockerised minicluster, but gives us > > coverage of remote read code paths for free, and more people care about > > that right now. > > > > I got the core end-to-end tests passing locally as part of > > https://issues.apache.org/jira/browse/IMPALA-7995. That change is up for > > review here https://gerrit.cloudera.org/c/12639/. The next step is to > get > > a > > Jenkins job running, which I've been working on. > > > > I'd like to run it regularly so we can catch any regressions. Initially > > I'll just have it email me when it fails, but after it's stable for a > week > > or two I'd like to make it part of the regular set of jobs. > > > > My preference is to run it as part of the precommit jobs, in parallel to > > the Ubuntu 16.04 tests. It should not extend the critical path of > precommit > > because it only runs the end-to-end tests. We could alternatively run it > as > > a scheduled post-commit job, but that tends to create additional work > when > > it breaks. > > > > What do people think? > > > > - Tim > > >
