I'm in favor of always displaying the number of instances. However, we're at 100 columns with the summary and should be mindful of users who display the summary in the impala-shell. How about using a short title, e.g. #Inst instead of #instances?
On Wed, Nov 20, 2019 at 9:50 AM Tim Armstrong <tarmstr...@cloudera.com> wrote: > > Do you know of any tools that rely on summary having only one of the > mentioned columns? > I don't know of any tools that consume the text representation of the exec > summary. Even if they did, I don't think they can reasonably expect that we > never change the format. > > > I managed to change the signature of the summary to have a #hosts and a > #instances column with the correct value. My question is should the > instances column only appear when mt_dop > 0, since the values would be the > same? > > I'd be inclined to always include the instances column so that the format > is consistent, even if the information is redundant. I don't feel that > strongly about it though - I can see the argument for reducing the amount > of data displayed. > > > > On Wed, Nov 20, 2019 at 4:27 AM Norbert Luksa <norbert.lu...@cloudera.com> > wrote: > > > Hi, > > > > I'm working on https://issues.apache.org/jira/browse/IMPALA-4618. > > > > I managed to change the signature of the summary to have a #hosts and a > > #instances column with the correct value. My question is should the > > instances column only appear when mt_dop > 0, since the values would be > the > > same? > > Do you know of any tools that rely on summary having only one of the > > mentioned columns? > > > > Thanks, > > Norbert > > >
