Use "refs/drafts/master" when you want to keep your code review private, i.e. only you and the explicitly added code reviewers see it. We usually do that when the work is in an early shape.
Otherwise it's OK to push to "refs/for/master". That said, I usually push all my CRs to "refs/for/master". When they are in an initial state I just add "WIP" (work in progress) to the title, so only the most enthusiastic code reviewers look at it. :) On Tue, Dec 14, 2021 at 3:34 PM 陈明雨 <morning...@163.com> wrote: > Oh, I see, I should to push to "refs/drafts/master" first. > Thanks for your reply. > > > > > > > > -- > > 此致！Best Regards > 陈明雨 Mingyu Chen > > Email: > chenmin...@apache.org > > > > > > 在 2021-12-14 20:43:59，"Zoltán Borók-Nagy" <borokna...@cloudera.com> 写道： > >Hi Mingyu, > > > >Thank you for your interest in the project. > >Seems like you've sent your patch to the 'refs/for/master' branch in > >gerrit, which means that the change request is already published. > >You already got some comments on your code. > > > >Cheers, > > Zoltan > > > > > >On Tue, Dec 14, 2021 at 9:38 AM 陈明雨 <morning...@163.com> wrote: > > > >> Hi: > >> I am trying to submit a pull request[1] to Gerrit. > >> And I followed the document [2] step by step. > >> > >> > >> But I can't find "publish" button. Could anyone help me? > >> > >> > >> [1] https://gerrit.cloudera.org/#/c/18091/ > >> [2] > >> > https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches > >> > >> -- > >> > >> 此致！Best Regards > >> 陈明雨 Mingyu Chen > >> > >> Email: > >> chenmin...@apache.org >
