KunalSiyag opened a new pull request, #84: URL: https://github.com/apache/impala/pull/84
Adds validation to reject non-numeric values (including empty strings) for numRows, totalSize, and rawDataSize table properties during ALTER TABLE SET TBLPROPERTIES operations. Previously, Impala allowed setting these properties to any string value, which could cause NumberFormatException errors in downstream applications like Spark when they tried to parse these values. Changes: - Added analyzeTableStatsProperties() method in AlterTableSetTblProperties.java that validates these properties contain parseable long values - Added corresponding test cases in AnalyzeDDLTest.java - Added new test file TableStatsValidationBugTest.java with comprehensive tests Testing: - All validation logic verified with unit tests - Tested that empty strings, non-numeric values, and whitespace-only values are correctly rejected with clear error messages - Tested that valid numeric values (including 0, -1, positive numbers) pass Example error messages: - "Table property 'numRows' must have a valid numeric value, got empty value." - "Table property 'numRows' must have a valid numeric value, got 'abc'." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
