Copilot commented on code in PR #89:
URL: https://github.com/apache/impala/pull/89#discussion_r3198400692
##########
be/src/util/hdfs-util.cc:
##########
@@ -51,6 +51,10 @@ string GetHdfsErrorMsg(const string& prefix, const string&
file) {
if (root_cause != nullptr) {
ss << "\nRoot cause: " << root_cause;
}
+ char* stack_trace = hdfsGetLastExceptionStackTrace();
+ if (stack_trace != nullptr) {
+ ss << "\nStack trace:\n" << stack_trace;
+ }
Review Comment:
GetHdfsErrorMsg now appends libhdfs exception stack trace (and previously
also appended the root cause), but the function’s documentation still describes
it as only prefix/file + errno. Please update the API comment (in hdfs-util.h)
so callers know the returned message may include multi-line Java exception
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
