Dan Hecht has posted comments on this change. Change subject: IMPALA-1886/IMPALA-2154: Add support for multi-stream bz2/gzip compressed files. ......................................................................
Patch Set 16: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2219/16/be/src/util/codec.h File be/src/util/codec.h: Line 130: /// stream_end: reached end of compressed stream. "end of output buffer corresponds to the end of a compressed stream" because in multi-stream, we could reach the end of one stream but start another, and don't want to return true in that case. -- To view, visit http://gerrit.cloudera.org:8080/2219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbe617d03a69953f0bf3aa0f7c30d34bc612f9f8 Gerrit-PatchSet: 16 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Skye Wanderman-Milne <s...@cloudera.com> Gerrit-HasComments: Yes
