Huaisi Xu has submitted this change and it was merged. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() ......................................................................
IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() Some TimestampValue converting functions assume caller ensures TimestampValue instance has a valid date or time but that's not true. Change those functions to return result in output parameter and return boolean to indicate the conversion is good or not. Change-Id: I7a68a1e14d9c4ee5d83da760d4d76c20c36bc359 (cherry picked from commit 47d8977f5976b9be405f44add966820138fbda6f) Reviewed-on: http://gerrit.cloudera.org:8080/2195 Reviewed-by: Juan Yu <j...@cloudera.com> Tested-by: Internal Jenkins (cherry picked from commit 02af7d30879e08b20df16b2fc4e3de7d06337d31) Reviewed-on: http://gerrit.cloudera.org:8080/2341 Reviewed-by: Huaisi Xu <h...@cloudera.com> Tested-by: Huaisi Xu <h...@cloudera.com> --- M be/src/exprs/aggregate-functions.cc M be/src/exprs/cast-functions.cc M be/src/exprs/timestamp-functions.cc M be/src/runtime/timestamp-test.cc M be/src/runtime/timestamp-value.h M tests/data_errors/test_data_errors.py 6 files changed, 134 insertions(+), 47 deletions(-) Approvals: Huaisi Xu: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a68a1e14d9c4ee5d83da760d4d76c20c36bc359 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <j...@cloudera.com>
