Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2585
Change subject: Preview: Re-enable Kudu in build using client stubs when needed ...................................................................... Preview: Re-enable Kudu in build using client stubs when needed (There's been a lot of discussion on this topic. I'm putting this out so people can see what the Impala code would look like. Generating the Kudu client stub as mentioned below is pretty trivial, but not included in this review. This wouldn't be the complete commit, tests would be added, etc, but this generally what it would look like.) The stubs in Impala broke during the merge commit. This commit removes the stubs in hopes of improving robustness of the build. The original problem (Kudu clients are only available for some OSs) is now addressed by moving the stubbing into a dummy Kudu client. (TBD: which project should be responsible for generating the dummy client.) The dummy client only allows linking to succeed, if any client method is called, Impala will crash. Before calling any such method, Kudu availability must be checked. Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 --- M CMakeLists.txt M be/CMakeLists.txt M be/src/common/global-flags.cc M be/src/common/init.cc M be/src/exec/CMakeLists.txt M be/src/exec/kudu-scan-node-test.cc M be/src/exec/kudu-scan-node.cc M be/src/exec/kudu-scan-node.h M be/src/exec/kudu-scanner.cc M be/src/exec/kudu-table-sink-test.cc M be/src/exec/kudu-table-sink.cc M be/src/exec/kudu-table-sink.h M be/src/exec/kudu-util.cc M be/src/exec/kudu-util.h M bin/bootstrap_toolchain.py M bin/impala-config.sh M common/thrift/generate_error_codes.py 17 files changed, 78 insertions(+), 129 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/85/2585/1 -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <ca...@cloudera.com>
