Casey Ching has posted comments on this change. Change subject: Don't link with binutils from the toolchain ......................................................................
Patch Set 1: > What happens when we do this? > Do you mean making this change? The system linker will be used, like it was before. This change was checked in on Friday. > I guess this is probably not a huge concern if we properly address > https://issues.cloudera.org/browse/IMPALA-3211 , but is maybe > something we need to understand better if we don't deal with that. Ya we need to think about this some. I think there are cases where we'll want to make changes to the way toolchain artifacts are built (your cmake change comes to mind) but that should be rare. Right now all the toolchain artifacts get overwritten with each build. Cloudera may need a layer of indirection for its builds. For example the 5.7 build could use a known version of the toolchain through some internal mirror. -- To view, visit http://gerrit.cloudera.org:8080/2587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e7db3008e935358e6c013b7a5104a4ce062440 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
