Juan Yu has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ......................................................................
Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/2543/5/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 159: int64_t* bytes_decompressed) { > Hm, maybe this is too fancy, but since callers don't usually use the bytes_ Done Line 180: if (stream_end) { > one line Done Line 244: int64_t truncated_decompressed = 0; > Put a comment above this line, like // Decompress the remaining Done Line 250: EXPECT_ERROR(StreamingDecompress(decompressor.get(), 16 * 1024 * 1024, > COMPRESSED_BUFFER_SIZE Done Line 258: // pick random size input data(~1MB), compress it, then concatenate those small > nit: Pick random-size input data (~1 MB) Done Line 270: raw_input[RAW_INPUT_SIZE] = 0; > Move L265-L270 to the top of the function, above the comment. This code is Done Line 272: while (*compressed_len < (COMPRESSED_BUFFER_SIZE - RAW_INPUT_SIZE) > Add a comment above this loop explaining why BUFFER_SIZE - RAW_INPUT_SIZE, Done -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Skye Wanderman-Milne <s...@cloudera.com> Gerrit-HasComments: Yes
