Juan Yu has posted comments on this change. Change subject: IMPALA-2076: Correct execution time for DataStreamSender. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2578/2/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: Line 249: /// Similar RPC call wrapper as DoRpc() but separate request and response so we could : /// profile thrift transmit time properly. > Are we okay with the increase in network traffic once we split this up? This is just for TransmitData(). It is two calls currently. I don't think it increase network traffic. void ImpalaInternalServiceClient::TransmitData(TTransmitDataResult& _return, const TTransmitDataParams& params) { send_TransmitData(params); recv_TransmitData(_return); } The recv_TransmitData() is used to control back pressure. if upstream node cannot consume data as fast as needed, this will slowdown sender to avoid data congestion. -- To view, visit http://gerrit.cloudera.org:8080/2578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c530b2056d852c8bcac6263e9e6b1a6bede1047 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
