Juan Yu has posted comments on this change. Change subject: IMPALA-2076: Correct execution time tracking for DataStreamSender. ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/2578/6/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: Line 40: if (transmit_csw_ != NULL) { > Are there any cases where we want to do TransmitData() but not set the csw? A couple of cases: 1. Status DataStreamSender::Channel::FlushAndSendEos(RuntimeState* state) this is not sending any data but just eos flag. 2. unit test, I could add a counter for data stream test. Line 46: recv_TransmitData > why don't we care about recv time? I explained this earlier, also mentioned in commit message. We only want to count the send_TransmitData() timing because that's the main job of DataStreamSender and that's where the network traffic spend. the recv_TransmitData() is mainly to wait for receiver to deserialize data and process data, not using much network, plus those part are already tracked by Exchange node. -- To view, visit http://gerrit.cloudera.org:8080/2578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c530b2056d852c8bcac6263e9e6b1a6bede1047 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
