Tim Armstrong has posted comments on this change. Change subject: IMPALA-3354: bad sorter pivot selection on some inputs ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/2824/5//COMMIT_MSG Commit Message: Line 15: always > delete Done http://gerrit.cloudera.org:8080/#/c/2824/5/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 246: parent > comment doesn't match the inputs -- maybe this is changing in your next pat Done Line 271: past > one past? Done Line 286: before > one before? Done Line 947: last > here and elsewhere: should 'last' be renamed 'end'? it looks like 'last' no Makes sense, I'll do it in the follow-up patch so that this can be more cleanly backported. -- To view, visit http://gerrit.cloudera.org:8080/2824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae50112b6deca3d6268e18b6f4daae1af279b452 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
