Matthew Jacobs has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2617/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 110: a an external Line 145: cursor.execute(""" : CREATE EXTERNAL TABLE %s : STORED AS KUDU : TBLPROPERTIES('kudu.table_name' = '%s')""" % ( : impala_table_name, preferred_kudu_table.name)) Hm, I don't think we should allow this behavior because there's no way to indicate which name ended up in the metastore. The user has to figure it out themselves which seems like it could cause issues. What was the reasoning behind allowing this? Line 183: cursor The same db is already the default db for this db, right? Can you add a comment to clarify -- To view, visit http://gerrit.cloudera.org:8080/2617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic141102818b6dad3016181b179a14024d0ff709d Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
