Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/10/tests/query_test/test_errorlog.py File tests/query_test/test_errorlog.py: Line 1: # Copyright (c) 2012 Cloudera, Inc. All rights reserved. only added test for merging error map.. the other one(print error map) is too tricky to add (require status is not ok. so if it cannot catch that in that same invokation then the query will be cancelled). and I already removed the print error map all together in hdfs-scan-node.cc Running private test now. should finish by tomorrow morning. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <h...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com> Gerrit-HasComments: Yes